pending() in beforeEach does not stop execution

[webmaster128]

Expected Behavior

Calling pending() in beforeEach should allow the user to prevent further execution of a spec.

Current Behavior

Calling pending() in the spec itself stops spec execution while calling it in beforeEach only marks the test as pending but does not stop execution.

Suite that reproduces the behavior (for bugs)

./node_modules/.bin/jasmine --random=false dummy.spec.js of

describe("pending in body", () => {
  it("should not explode", () => {
    pending("Stop execution or things will explode");
    console.log("body: boom!");
  });
});

describe("pending in beforeEach", () => {
  beforeEach(() => pending("Stop execution or things will explode"));

  it("should not explode", () => {
    console.log("beforeEach: boom!");
  });
});

prints

Started
*beforeEach: boom!
*

Pending:

1) pending in body should not explode
  Stop execution or things will explode


2) pending in beforeEach should not explode
  Stop execution or things will explode

2 specs, 0 failures, 2 pending specs
Finished in 0.009 seconds

Context

In our environment we want to selectively stop test execution for client-server tests when server is not there. Marking the spec as pending is not sufficient since a complex initialization is started that leads to some very hard to debug exceptions in afterAll.

Your Environment

• node v8.10.0
• jasmine 3.1.0

[slackersoft]

The current mechanism for this is the --stop-on-failure CLI argument. This is also configurable in your jasmine.json as stopSpecOnExpectationFailure. If this isn't working with pending() we definitely need to fix that.

I would also be happy to review a pull request that makes pending() always behave as if stopSpecOnExpectationFailure is set.

Hope this helps. Thanks for using Jasmine!

[johnjbarton]

We hit a similar issue, but I am confused by the answer here.

If we set stopSpecOnExpectationFailure, the pending() will work when called in beforeAll()?

[slackersoft]

stopSpecOnExpectationFailure should only affect what pending does in a beforeEach not a beforeAll. Jasmine runs a beforeAll as part of a suite, where a beforeEach is run as part of a spec.

[johnjbarton]

Thanks, so what should pending() mean in beforeAll()? I believe the intention was for the entire suite to be set pending, but that was not the result.

[slackersoft]

A call to pending() from a beforeAll should mark all specs within the describe as pending, but Jasmine may still run them as long as their status continues to be pending after execution. This should be similar to how calling pending works within a beforeEach without stopSpecOnExpectationFailure (or oneFailurePerSpec) enabled.

This may be a future looking statement, I'm not sure that Jasmine has any tests that assert on the interaction of pending and beforeAll. If this isn't the case currently, I would also be happy to review a pull request to at least define that functionality. Given the current mechanisms for handling exiting early, I'm not sure what the effort would be to make pending also exit the describe early without exiting the entire suite.