Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Issue: suiteDone gets emitted for top suit #706

Closed
gyandeeps opened this issue Nov 15, 2014 · 0 comments
Closed

Breaking Issue: suiteDone gets emitted for top suit #706

gyandeeps opened this issue Nov 15, 2014 · 0 comments

Comments

@gyandeeps
Copy link

The top level suite (suite0 per say) which emits a suiteDone event but never emits a suiteStart event.

So all the reporters who listen for these events throw error because they never received a suiteStart for suite0 but at the end they received suiteDone for suite0.
But I think that if this top level suite is for internal jasmine purpose then either it should emit both the events or neither.

This has happened in new version 2.1.0 at this revision: 9402d59#diff-f41e57b2889bae3046aa9f352699785cR182

grunt-contrib-jasmine is breaking too. gruntjs/grunt-contrib-jasmine#181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gyandeeps