Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement spies for get/set functions on accessor properties #1203

Merged
merged 2 commits into from Nov 4, 2016
Merged

Implement spies for get/set functions on accessor properties #1203

merged 2 commits into from Nov 4, 2016

Conversation

celluj34
Copy link

This PR is a rebased version of #1008 against the current master branch of jasmine/jasmine, SHA 8624a52.

I have proposed this to hopefully get this feature into base, fixing the merge conflicts, as the original PR author has not yes updated his PR.

@celluj34
Copy link
Author

@smacker, @brunoskonrad, @henrahmagix, @gantaa, @erwinverdonk, I have rebased the old PR. Let me know if there's anything else that should be done.

@henrahmagix
Copy link
Contributor

👍 nice one @celluj34

@henrahmagix
Copy link
Contributor

Now either can be merged; I hope one is :)

@erwinverdonk
Copy link

@celluj34 Thank you so much for making this new PR without conflicts. Truly appreciated!

@vchu-vr
Copy link

vchu-vr commented Nov 2, 2016

Is there a timeline for merging?

@celluj34
Copy link
Author

celluj34 commented Nov 3, 2016

@slackersoft Can you take a look at this? There are many people that would love to see this merged, myself included. Let us know if there's anything else that needs to be done.

@slackersoft slackersoft merged commit 8e23c26 into jasmine:master Nov 4, 2016
slackersoft pushed a commit that referenced this pull request Nov 4, 2016
…into celluj34-spyOnProperty2

- Merges #1203 from @celluj34
- Merges #1008 from @smacker
- Fixes #943
@celluj34 celluj34 deleted the spyOnProperty2 branch November 5, 2016 00:54
@henrahmagix
Copy link
Contributor

Thanks @slackersoft!

@sgruhier
Copy link

when will be the next release with this PR?

@Narretz
Copy link

Narretz commented May 10, 2017

This is in 2.6, but are there any docs for this?

@slackersoft
Copy link
Member

@celluj34
Copy link
Author

localhost?

@slackersoft
Copy link
Member

Sorry, I must have grabbed the wrong tab. Try this: https://jasmine.github.io/api/edge/global.html#spyOnProperty

@celluj34
Copy link
Author

Neat. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants