New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement spies for get/set functions on accessor properties #1203
Conversation
Needed adding to the env and require interface
@smacker, @brunoskonrad, @henrahmagix, @gantaa, @erwinverdonk, I have rebased the old PR. Let me know if there's anything else that should be done. |
👍 nice one @celluj34 |
Now either can be merged; I hope one is :) |
@celluj34 Thank you so much for making this new PR without conflicts. Truly appreciated! |
Is there a timeline for merging? |
@slackersoft Can you take a look at this? There are many people that would love to see this merged, myself included. Let us know if there's anything else that needs to be done. |
Thanks @slackersoft! |
when will be the next release with this PR? |
This is in 2.6, but are there any docs for this? |
The docs are here: http://localhost:4000/api/edge/global.html#spyOnProperty |
localhost? |
Sorry, I must have grabbed the wrong tab. Try this: https://jasmine.github.io/api/edge/global.html#spyOnProperty |
Neat. Thanks! |
This PR is a rebased version of #1008 against the current master branch of jasmine/jasmine, SHA 8624a52.
I have proposed this to hopefully get this feature into base, fixing the merge conflicts, as the original PR author has not yes updated his PR.