afterEach blocks are not aborted after a timeout in waitsFor #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. However, we're no longer supporting 1.3 due to focus on 2.0, which I think does have this functionality. Are you able to move your project to 2.0? |
|
No I don't believe we'll be able to move 20K+ specs to Jasmine 2.0, it's not worth the time. There may be a lot of other projects out there stuck with 1.x, and this bug is pretty severe IMO. Hence the PR. |
|
I'm fine for having your fork be canonical 1.3 with fixes. Does that work for you? |
|
Not sure what you mean by that? |
|
@infews Sorry for the delay. So just to make it clear, are you proposing that I would take over 1.3 maintenance in my branch? I'm fine with that overall, just not clear on the mechanics of how that is supposed to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a timeout in
waitsForcaused the block queue for a spec to be aborted, and ifwhatsForblock happened not to be the last one before "ensured"afterEachblocks they were never executed. This is a bug.With this fix, the queue will continue to run until all blocks are exhausted but only "ensured" blocks are executed when abort condition is met.