Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subjective readability improvements to CONTRIBUTING.md #815

Merged

Conversation

jhamon
Copy link
Contributor

@jhamon jhamon commented Apr 1, 2015

I started to study this document and some things at the beginning seemed like they were more difficult to read/scan than they should be. These are mostly formatting changes, with very minor changes to wording. Open to feedback or rejection, of course, since other peoples' style preferences may differ.

@infews
Copy link
Contributor

infews commented Apr 1, 2015

Nicely done! Thanks for the help.

@infews infews closed this Apr 1, 2015
@jhamon
Copy link
Contributor Author

jhamon commented Apr 2, 2015

Not trying to be a pest, but I'm getting mixed signals from your comment. Did you mean to close without merging?

@infews infews reopened this Apr 2, 2015
infews added a commit that referenced this pull request Apr 2, 2015
…ty-improvements

Subjective readability improvements to CONTRIBUTING.md
@infews infews merged commit 2d5c071 into jasmine:master Apr 2, 2015
@infews
Copy link
Contributor

infews commented Apr 2, 2015

No. Total brain fade on my part. Thanks for the poke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants