Fix 404 handling #65 #57 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonacox
commented
Jan 13, 2024
| if r.status_code == 404: | ||
| # API not found or no longer supported | ||
| log.debug('ERROR Powerwall API not found at %s' % url) | ||
| return None |
There was a problem hiding this comment.
A 404 status response for an API call will now result in a None response and log a debug message.
jasonacox
commented
Jan 13, 2024
| let timerInterval = setInterval(updateCountdown, 1000); | ||
| </script> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Simple landing redirect page for pypowerwall.com.
|
https://pypi.org/project/pypowerwall/0.7.6/ jasonacox/pypowerwall:0.7.6t39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug in pypowerwall related to API calls and 404 HTTP status codes handling.
Powerwall Firmware version 23.44.0 has eliminated /api/devices/vitals resulting in a 404 response from the Powerwall Gateway (TEG) when this is requested. There is a bug in the pypowerwall code that will treat this 404 like an authentication failure which will result in attempts to log in over and over, eventually hitting the rate limit. This is especially impactful for those using the proxy for things like Powerwall-Dashboard as the rate limit will prohibit other data gathering.
Related issue: #57
Closes #65