-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #29 - Show batch (i.e. stint) info after name on correct guess #49
Issue #29 - Show batch (i.e. stint) info after name on correct guess #49
Conversation
Would love to hear your thoughts, @botwhytho and @brainwane, since you were the original submitter and commenter on #29. But no pressure if you don't have the bandwidth to weigh in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work, @jaryncolbert ! Thank you so much. It looks amazing, and you handled the edge cases really well; I really appreciate your thoroughness.
There are some opportunities to clean up the code a little bit, or places where I don't quite follow, and I've commented on them below. They're all optional, though - if you want to work on it further, I'm happy to pair on and/or review that work, and if not then please merge away!
… relevant dates, etc.) for correct guess
…from Flask in ISO 6801 format.
6fae9b2
to
dfc45ae
Compare
return stint.get('short_name'); | ||
} | ||
|
||
switch (type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the 'retreat'
case is a simple return
, I think it makes sense to merge the if
statement into the switch
statement, like:
switch (type) {
case 'retreat':
return stint.get('short_name');
case 'residency':
Thanks, @jaryncolbert ! 💜 |
This commit resolves #29 by adding information about a member of the RC community's stint or tenure depending on their role and the dates of their involvement.
m3'19
orSP1'19
.Resident
title
, if specified. Otherwise,Staff
.Experimental Batch
Research Fellow
Facilitator
Apr '19
.<role> since <start_date>
, e.g.Facilitator since Jan '14
.<role>, <start_date> - <end_date>
, e.g.Resident, Sep '13 - Dec '13
. If the start and end dates have the same abbreviation, only a single date will be shown, e.g.<role>, <start_date>
, e.g.Experimental Batch, Jul '17
.Screenshots -
Career Facilitator
but without end date: