Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When you guess correctly display the person's batch information after their name #29

Closed
botwhytho opened this issue Mar 31, 2017 · 2 comments · Fixed by #49
Closed

When you guess correctly display the person's batch information after their name #29

botwhytho opened this issue Mar 31, 2017 · 2 comments · Fixed by #49
Labels
back-end Relating to the server-side Python code enhancement front-end Relating to the client-side JavaScript help wanted

Comments

@botwhytho
Copy link
Collaborator

This might help people beginning a batch know who's in their batch 😄
@botwhytho botwhytho mentioned this issue Apr 1, 2017
Closed
@botwhytho botwhytho changed the title When you guess correctly display the person's batch name after their name When you guess correctly display the person's batch information after their name Apr 1, 2017
@jasonaowen jasonaowen added back-end Relating to the server-side Python code front-end Relating to the client-side JavaScript labels Apr 5, 2019
@jasonaowen
Copy link
Owner

This will require fixing #42 , adding the batch name to the API response, and then showing the batch name in React.

The convention in RC is to show the most recent batch they've done, so that's probably what we want to do? Or maybe we should show both - ie Full Name (Winter 2, 2017; Spring 2, 2019)?

@brainwane
Copy link

I have been in multiple batches, so it would be great to know "which batch was this person in with me?"

And if they've been in multiple batches, I'd want to know that too.

jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 24, 2019
@jaryncolbert
Show tenure information (batch name, employment title, relevant dates…
f872e43 
…, etc.), as appropriate for correct guess.

Issue jasonaowen#29 - Show batch (i.e. stint) info after name on correct guess
@jaryncolbert jaryncolbert mentioned this issue Apr 24, 2019
Merged
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 29, 2019
@jaryncolbert
Fixes jasonaowen#29 - Show tenure info (batch name, employment title,…
2988d3d 
… relevant dates, etc.) for correct guess
jaryncolbert added a commit to jaryncolbert/recurse-faces that referenced this issue Apr 29, 2019
@jaryncolbert
Fixes jasonaowen#29 - Show tenure info (batch name, employment title,…
f8d4858 
… relevant dates, etc.) for correct guess
jaryncolbert added a commit that referenced this issue Apr 29, 2019
@jaryncolbert
Merge pull request #49 from jaryncolbert/29_display_batch
22a1af9 
Issue #29 - Show batch (i.e. stint) info after name on correct guess
jaryncolbert added a commit that referenced this issue Apr 29, 2019
@jaryncolbert
Cleanup from #29/#49 to add 'retreat' case to switch statement
253d81e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back-end Relating to the server-side Python code enhancement front-end Relating to the client-side JavaScript help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #29 - Show batch (i.e. stint) info after name on correct guess jaryncolbert/recurse-faces
3 participants
@brainwane @jasonaowen @botwhytho