got smarter search, async stuff, lazy load thumbnails, infinite scrolling #25
Conversation
|
|
| do { | ||
| for row in try db.prepare(query) { | ||
| let frameId = row[allText[frameId]] |
| value.forEach { v in | ||
| offsetToId[v.1] = v.0 | ||
| } | ||
| let imageSequence = DatabaseManager.shared.getImages(filePath: key, frameOffsets: frameOffsets, maxSize: CGSize(width: 600, height: 600)) |
There was a problem hiding this comment.
batched async retrieval, which calls updateThumbnail on published thumbnail for that sweet async update
| debounceTimer?.invalidate() | ||
| analyzeImage(image) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
getting rid of this should fix a lot of issues due to all kinds of logic happening in CustomHostingControllerRepresentable like binding keys for quitting...
| @@ -307,8 +326,8 @@ class TimelineViewModel: ObservableObject { | |||
| } | |||
|
|
|||
| func updateIndexSafely() { | |||
| let rounded = Int64(currentFrameContinuous) | |||
| if DatabaseManager.shared.getFrame(forIndex: rounded) != nil { | |||
| indexUpdateThrottle.throttle { | |||
There was a problem hiding this comment.
throttling for stability...
| DispatchQueue.main.async { | ||
| self.searchViewWindow?.orderFrontRegardless() // Ensure it comes to the front | ||
| } |
There was a problem hiding this comment.
someone explain main thread / ui thread in relation to dispatchqueue to me please
| .onScrollToBottom { | ||
| Task { | ||
| loadMoreResults() | ||
| } | ||
| } |
There was a problem hiding this comment.
trigger infinite load
| @@ -56,8 +57,7 @@ struct SearchBar: View { | |||
| } | |||
| } // Trigger search when user submits | |||
| .onChange(of: text) { | |||
| debounceTimer?.invalidate() | |||
| debounceTimer = Timer.scheduledTimer(withTimeInterval: 0.3, repeats: false) { _ in | |||
| debounceSearch.debounce { | |||
| let aI = try generator.copyCGImage(at: a, actualTime: nil) | ||
| return aI | ||
| } catch { | ||
| print("Error extracting frame \(videoURL): \(error)") | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| func extractFrames(from videoURL: URL, frameOffsets: [Int64], maxSize: CGSize? = nil) -> AVAssetImageGenerator.Images { |
There was a problem hiding this comment.
batch retrieval. so really we should be doing this in timeline too, but #7 should be much more easily solvable with this. "are we near a new chunk? load the whole thing"
| if !FileManager.default.fileExists(atPath: videoURL.path) { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
omg file io ON EVERY SINGLE SEARCH RESULT
someone else take over this project
I shouldn't have stayed up all night BUT
scrolling.mp4