[fixed] encoded ampersands in query params

fixes remix-run#343
jasonkenneth · Oct 7, 2014 · 60f9eb4 · 60f9eb4
1 parent acc00f7
commit 60f9eb4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/modules/utils/Path.js b/modules/utils/Path.js
@@ -112,7 +112,7 @@ var Path = {
    * in the given path, null if the path contains no query string.
    */
   extractQuery: function (path) {
-    var match = decodeURL(path).match(queryMatcher);
+    var match = path.match(queryMatcher);
     return match && qs.parse(match[1]);
   },
 

diff --git a/modules/utils/__tests__/Path-test.js b/modules/utils/__tests__/Path-test.js
@@ -229,6 +229,10 @@ describe('Path.extractQuery', function () {
     it('properly handles arrays', function () {
       expect(Path.extractQuery('/?id%5B%5D=a&id%5B%5D=b')).toEqual({ id: [ 'a', 'b' ] });
     });
+
+    it('properly handles encoded ampersands', function () {
+      expect(Path.extractQuery('/?id=a%26b')).toEqual({ id: 'a&b' });
+    });
   });
 
   describe('when the path does not contain a query string', function () {