Supporting (escaped) ampersands in query

[agundermann]

If I do a transition with a query such as { foo: "bar&baz"}, it will be correctly encoded in the URL as ?foo=bar%26bar, but the query inside the page handler ends up being {foo: "bar", baz: ""}.

[ryanflorence]

A failing test case would be awesome here. Think you can make one and send a pull request? (Just with the test case, don't need the fix.)

Probably do an injectParams in: https://github.com/rackt/react-router/blob/master/modules/utils/__tests__/Path-test.js

[agundermann]

There you go #355

[ryanflorence]

The test passes ... are you sure of the issue in your handler?

[agundermann]

That's surprising. It fails for me with AssertionError: {"id":"a","b":""} deepEqual {"id":"a&b"} .

Looking at the implementation, I don't see how this test could pass. The URL is decoded via decodeURIComponent before qs.parse is called, so it should be impossible for qs.parse to distinguish between separators and those ampersands wanted inside values. Removing the decodeURL call lets the test pass for me.

Am I missing something?

I don't think it matters, but I'm using Windows 8.1 and Chrome 37.0.2062 .

[ryanflorence]

oh, I'm sorry, I mistook github's "this can be merged" for "everything is great on travis ci!" :\

Thank you for the test case!

[agundermann]

Thank you for resolving this. Glad I could contribute 😄