Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, I attach a file to an email, and it's confirmed uploaded. But then, when I send, the attachment is not part of sent email #421

Closed
marclaporte opened this issue Aug 11, 2020 · 12 comments · Fixed by #453
Assignees
Labels
bug something is wrong in Cypht smtp smtp module set
Milestone

Comments

@marclaporte
Copy link
Member

Seen by at least Jason and myself. No pattern to reproduce yet.

https://gitter.im/cypht-org/community?at=5f307abefe39ca5d65902d7c

@jasonmunro jasonmunro self-assigned this Sep 16, 2020
@jasonmunro jasonmunro added bug something is wrong in Cypht smtp smtp module set labels Sep 16, 2020
@marclaporte
Copy link
Member Author

But I am 99% sure root cause is identical to this other bug we can replicate: #420

@marclaporte
Copy link
Member Author

marclaporte commented Feb 10, 2021

Ok, looks like I was wrong in previous message (!) But I am now 99% sure [ will I ever learn? :-) ] that it's related to #436

To see some weirdness with attachments: On a message, click "forward", then back (with your browser), then forward again, etc. It is possible that on your first "forward" click, the email will be blank, and you'll have an attachment (mail.mime message/rfc822), then, on each browser "back" and Cypht "forward", you may end up with an extra attachment.

@marclaporte
Copy link
Member Author

I got this again with latest Tiki 21.x which includes #453

But I can't find a pattern to reproduce.

@marclaporte
Copy link
Member Author

Related commit: https://gitlab.com/tikiwiki/tiki/-/commit/caf8c793877b6831278c59003ece3250fcd2992e

This likely solves the issue for Cypht in Tiki. But Jason had noticed this (or a similar issue) in standalone Cypht. So there is perhaps another issue, but that we can't reproduce.

So I will close this for now, and re-open if I see the behavior again.

Prepare for next release (1.3.0) automation moved this from bugs to done Jun 22, 2021
@marclaporte
Copy link
Member Author

Victor found the issue. Merge request coming soon.

@marclaporte marclaporte reopened this Aug 27, 2021
@marclaporte
Copy link
Member Author

Here is, with a good discussion: #508

@marclaporte
Copy link
Member Author

@henrique-borba: With latest code, these are two issues:

How to reproduce:
1- Click to compose a new email
2- Fill out text fields
3- Click Save (it will confirm it saved a drat)
4- Upload an image
5- Send

Issues:
1- Email is sent without attachment
2- Draft email subsists in draft folder

Thanks!

@marclaporte
Copy link
Member Author

This will be solved by #524

@marclaporte
Copy link
Member Author

It also needed #548

@marclaporte
Copy link
Member Author

@NasserNgandu found a pattern which related to folder permissions where files are temporarily stored. He will add an error message if folder is not writable.

@marclaporte marclaporte reopened this Jul 10, 2022
@marclaporte
Copy link
Member Author

Possible fix: #575

@marclaporte marclaporte added this to the 1.4 milestone Jul 31, 2022
@marclaporte
Copy link
Member Author

I haven't seen this issue in a while, so presuming fixed. Will re-open if I encounter again

Prepare for next release (1.3.0) automation moved this from bugs to done Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in Cypht smtp smtp module set
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants