Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Read missing values from sav/readstat into column empty values #2500

Closed
JorisGoosen opened this issue Jan 3, 2024 · 11 comments

Comments

@JorisGoosen
Copy link
Contributor

JorisGoosen commented Jan 3, 2024

Description

SPSS files can contain well defined per column missing values. These are currently read by JASP and are interpreted correctly as missing values. But they are not stored in the column.

Purpose

Make use of added functionality from jasp-stats/jasp-desktop#5276 to store missing values properly from SPSS

Use-case

pretty obvious I think

@tomtomme
Copy link
Member

All stuff related to "missing values"
#2575
#2500
#2437
#396

@JorisGoosen
Copy link
Contributor Author

@tomtomme do you have an example sav file for this?
I dont really want to buy a license for SPSS just to test this

@tomtomme
Copy link
Member

Not until tuesday. If you need it earlier you could produce one with pspp. It is open source.
I have no access to a pc atm.

@JorisGoosen
Copy link
Contributor Author

No hurry!

@shun2wang
Copy link
Contributor

@tomtomme
Copy link
Member

tomtomme commented Apr 2, 2024

@JorisGoosen
Here is a nice big one with lots of labels and missing values defined
missings.sav.zip

The first 8 variables should cover most combinations of variable type and sort of missing value (range, single value, string etc.)

Besides the information of the "missing values" we should also import description, type etc.
So from the screenshot below the columns number:
1 Name
2 type (numeric or string or date etc.)
5 Description
6 Labels
7 Missing Values
10 type (scale, ordinal, nominal, nominal text)

grafik

JorisGoosen added a commit to jasp-stats/jasp-desktop that referenced this issue Apr 2, 2024
Implements most jasp-stats/jasp-issues#2500
Seems missing values defined as ">97, <99" dont work yet, but this should cover most uses probably
@JorisGoosen
Copy link
Contributor Author

Im going to leave out the support for the min<X<max missing values because it doesnt really fit with the way they work in JASP.

Unless of course this is an indispensable feature, then Im sure we could cobble something together, but it would probably require some extra stuff in JASP.

@shun2wang
Copy link
Contributor

shun2wang commented Apr 3, 2024

Here in readstat has a metadata for dataset files type and "missing", and also in readstat.h wich will including some custom missing value and system missing.

@tomtomme
Copy link
Member

tomtomme commented Apr 3, 2024

@JorisGoosen
It is lower prio I think. So from my perspective leave it out for now.

Did you close the issue on purpose? Is this already implemented?

@JorisGoosen
Copy link
Contributor Author

I closed it on purpose indeed, see: jasp-stats/jasp-desktop@79ef8b5

@JorisGoosen
Copy link
Contributor Author

Here in readstat has a metadata for dataset files type and "missing", and also in readstat.h wich will including some custom missing value and system missing.

I know, im using them ^^
https://github.com/jasp-stats/jasp-desktop/blob/ab341fc7a580bc20976185df67054873c7d15803/Desktop/data/importers/readstat/readstatimportcolumn.cpp#L69-L85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants