-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete labeling of outliers #387
Comments
@AlexanderLyNL in your PR jasp-stats/jasp-desktop#3320 you changed the quantile algorithm type from 7 (R standard) to 6 (SPSS standard). This gives different quantiles. ggplot does not allow you to set the quantile type and by default uses type 7. I also noticed we use I think the only way to change the ggplot is to completely overwrite the boxplot element and add our own outlier dots. Should we really perform this switch from 7 to 6? |
I have a strong preference for whatever R uses over whatever SPSS uses... |
Sure we can change everything from 6 to 7. Would you like to do this? Or should I? |
Yeah I can do it -- I was just wondering what the best course of action was |
I thought that it would be good to have the output consistent with SPSS, but that doesn't seem to be the case, so let's follow the R default instead. |
* Fix jasp-stats/jasp-issues#387 (use type=7 quantiles) * Show col names in failing unit tests
The text was updated successfully, but these errors were encountered: