Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete labeling of outliers #387

Closed
karenzagorski opened this issue Jun 16, 2019 · 5 comments
Closed

Incomplete labeling of outliers #387

karenzagorski opened this issue Jun 16, 2019 · 5 comments
Assignees

Comments

@karenzagorski
Copy link

  • JASP version: 0.10
  • OS name and version:Windows, Version 10.0.17134 Build 17134
  • Analysis: Side-by-Side boxplots with labeled outliers
  • Bug description: Some outliers don't get labels
  • Add JASP files as a zip:bug report.zip1
  • Screenshot: 1
  • Expected behaviour: All outliers should have a label
  • Steps to reproduce:
  1. Descriptive statistics. Lifespan(variables) vs exposure(split)
  2. Plot as box plot. Check label outliers
  3. Groups 2 4 and 5 have unlabeled outliers, group 1 is labeled properly
@TimKDJ TimKDJ self-assigned this Jun 19, 2019
@TimKDJ
Copy link

TimKDJ commented Jun 19, 2019

@AlexanderLyNL in your PR jasp-stats/jasp-desktop#3320 you changed the quantile algorithm type from 7 (R standard) to 6 (SPSS standard). This gives different quantiles. ggplot does not allow you to set the quantile type and by default uses type 7. I also noticed we use quantile() in other analyses and do not use type 6.

I think the only way to change the ggplot is to completely overwrite the boxplot element and add our own outlier dots. Should we really perform this switch from 7 to 6?

@EJWagenmakers
Copy link
Collaborator

I have a strong preference for whatever R uses over whatever SPSS uses...

@AlexanderLyNL
Copy link
Contributor

Sure we can change everything from 6 to 7. Would you like to do this? Or should I?

@TimKDJ
Copy link

TimKDJ commented Jun 19, 2019

Yeah I can do it -- I was just wondering what the best course of action was

@AlexanderLyNL
Copy link
Contributor

I thought that it would be good to have the output consistent with SPSS, but that doesn't seem to be the case, so let's follow the R default instead.

TimKDJ added a commit to TimKDJ/jasp-desktop that referenced this issue Jun 19, 2019
TimKDJ added a commit to TimKDJ/jasp-desktop that referenced this issue Jun 20, 2019
gibbona1 pushed a commit to gibbona1/jasp-desktop that referenced this issue Jul 12, 2019
* Fix jasp-stats/jasp-issues#387 (use type=7 quantiles)

* Show col names in failing unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants