-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coefficient of variation added to the descriptives tables of all TTests #122
Coefficient of variation added to the descriptives tables of all TTests #122
Conversation
All checks failed, because the new descriptives tables have more cells than the old ones. Is there anything I can do to avoid this or is this not a problem? |
You will need to update the tests; you can follow this guide: https://github.com/jasp-stats/jasp-desktop/blob/development/Docs/development/r-unit-test-guide.md Let me know if anything is unclear! |
Thanks a lot! And I will :)
Op ma 4 apr. 2022 om 10:48 schreef Simon Kucharsky ***@***.***
…:
You will need to update the tests; you can follow this guide:
https://github.com/jasp-stats/jasp-desktop/blob/development/Docs/development/r-unit-test-guide.md
Let me know if anything is unclear!
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWNHG3Z5WSTTK5MOBJ4TLJ3VDKUFFANCNFSM5SOU7PDQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I've updated the tests and the checks have passed :). Shall I now add the coefficient of variation to the descriptives tables of the AN(C)OVA's? I noticed that SE's are also missing in the descriptives tables of AN(C)OVA's; is there a reason for this or should I add those aswell? Also, I noticed that the order of the columns of the descriptives tables is slightly different from those in the TTests; is there a reason for this or should I rearrange the columns so they match those of the TTests? Thanks in advance :)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looking pretty solid, good work! There is just one suggestion to use consistent variable name and we need to discuss what do we do with a verified test.
Yes please!
Yes, it would be great to make the tables consistent between T-Tests and ANOVAs :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
part of jasp-stats/jasp-issues#1599