Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coefficient of variation added to the descriptives tables of all TTests #122

Merged
merged 8 commits into from
Apr 22, 2022

Conversation

LSLindeloo
Copy link
Contributor

@LSLindeloo LSLindeloo commented Apr 4, 2022

@LSLindeloo
Copy link
Contributor Author

All checks failed, because the new descriptives tables have more cells than the old ones. Is there anything I can do to avoid this or is this not a problem?

@Kucharssim
Copy link
Member

You will need to update the tests; you can follow this guide: https://github.com/jasp-stats/jasp-desktop/blob/development/Docs/development/r-unit-test-guide.md

Let me know if anything is unclear!

@LSLindeloo
Copy link
Contributor Author

LSLindeloo commented Apr 4, 2022 via email

@LSLindeloo
Copy link
Contributor Author

I've updated the tests and the checks have passed :). Shall I now add the coefficient of variation to the descriptives tables of the AN(C)OVA's? I noticed that SE's are also missing in the descriptives tables of AN(C)OVA's; is there a reason for this or should I add those aswell? Also, I noticed that the order of the columns of the descriptives tables is slightly different from those in the TTests; is there a reason for this or should I rearrange the columns so they match those of the TTests?

Thanks in advance :)!

Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looking pretty solid, good work! There is just one suggestion to use consistent variable name and we need to discuss what do we do with a verified test.

R/commonbayesianttest.R Outdated Show resolved Hide resolved
@Kucharssim
Copy link
Member

Shall I now add the coefficient of variation to the descriptives tables of the AN(C)OVA's?

Yes please!

I noticed that SE's are also missing in the descriptives tables of AN(C)OVA's; is there a reason for this or should I add those aswell? Also, I noticed that the order of the columns of the descriptives tables is slightly different from those in the TTests; is there a reason for this or should I rearrange the columns so they match those of the TTests?

Yes, it would be great to make the tables consistent between T-Tests and ANOVAs :)

Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@Kucharssim Kucharssim merged commit f9760bf into jasp-stats:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants