Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bayesian t-test uses frequentist data reader #258

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

JohnnyDoorn
Copy link
Contributor

@vandenman
Copy link
Contributor

vandenman commented Jun 18, 2024

The changes look fine but I don't understand why the unit tests fail..., let's see if they also fail in #262, otherwise, I'll try to reproduce this locally. Those tests don't run because no R code changed 🙃

@JohnnyDoorn
Copy link
Contributor Author

Its just some rng thing no?

@vandenman
Copy link
Contributor

It's the same test on each OS, and the error is the same for macOS and Ubuntu but different on Windows. I just want to make sure it's got nothing to do with the specific stuff for handling ordinal input.

@vandenman
Copy link
Contributor

and fix the test if I can :)

@vandenman
Copy link
Contributor

# ???: the error statistic differs between osx <-> windows. if anyone can figure out why i'd be interested (especially because the BF is the same)
# vandenman: The difference appears in integrate, for example:
# BayesFactor:::meta.bf.interval(-Inf, Inf, t = 0.158315759266202, N = 50000, df = 199998, rscale = 0.707)
if (identical(.Platform$OS.type, "windows"))
jaspTools::expect_equal_tables(table, list(0.00511047754408505, 4.61848285988607, "dependent_var"))
else
jaspTools::expect_equal_tables(table, list(0.00511048079567079, 0.185588508623007, "dependent_var"))

Always fun to encounter your past self in some obscure comment somewhere...

@vandenman vandenman merged commit 1da654b into jasp-stats:master Jun 18, 2024
5 checks passed
@JohnnyDoorn
Copy link
Contributor Author

Haha awesome, then we get it right for at least 1 OS ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bayesian Paired-Samples t-test (Wilcoxon) - Won't run with ordinal data, but will with scale data.
2 participants