-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use https github enterprise #20
Comments
Allo? |
Sorry for late reply. Jasper supports https GHE. |
I found the issue: Jasper does not handle cert files. |
Please check v0.2.4-beta.1 |
I'm tried and get failed to use Jasper app with GitHub enterprise. Configure the GitHub enterprise host, input the personal access token, click the What can I do to use the app? My environment:
|
I have met similar issue.
I've tried run jasper by
I've used |
jasper works fine with http and https, the main issue is when you needs certificates to be trusted on your github enterprise landscape. I found a work around that inject the certificates (2 lines of code) but we really need a proper development on the top of it. Hope jasper developers will read this :) |
Jasper uses the following code. const options = {
hostname: this._host,
port: this._https ? 443 : 80,
path: requestPath,
headers: {
'User-Agent': this._userAgent,
'Authorization': `token ${this._accessToken}`
}
};
const httpModule = this._https ? https : http;
this._log(path, query);
const req = httpModule.request(
options,
this._onResponse.bind(this, resolve, reject)
).on('error', (e)=> reject(e)); I think that other cause in this bug. |
@elanciel Thanks for the comment.
Could you tell me the code? |
Maybe, this is other issue. I've set GHE setting and launched jasper, then loading forever. Does jasper use |
I'm trying Jasper under the similar situation as follows, but I can't.
I also tried with electron command with Is it possible to avoid the error? |
Finally, I could connect in my environment. All things what I did as follows:
I hope this will help. |
@azu Jasper fixed to work on http GHE. Please update to v0.4.0 👍 |
@h13i32maru Has this been fixed? I'm in the same problem. Is there any validation rule for host format? My environment: Jasper app 0.5.0 |
I'm on 0.9.2, and this still doesn't work. Pity. |
I just downloaded and I'm also having this issue. version 1.0.7 |
Hi I cannot use the https github enterprise github mode...
Is it normal or a bug ?
Regards.
Richard.
The text was updated successfully, but these errors were encountered: