Upgrade Electron to v5.0.0 #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades Electron to the latest beta (the final release should be not far behind!) and fixes the window creation code to explicitly enable the `nodeIntegration` that content pages currently rely on. In Electron 5, without `nodeIntergration` explicitly enabled, the content pages do not have access to `require`!
|
Thank you for this PR 😄 |
|
It looks like the instructions in the read me are still wrong, you could at least cherry-pick 26c7f85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Electron to the latest major version, and fixes the window creation code to explicitly enable the
nodeIntegrationthat content pages currently rely on.In Electron 5, without
nodeIntergrationexplicitly enabled, the content pages do not have access torequire!