New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client SSL configuration #214
Conversation
Some mysql tests are failing. I suspect it is related to the testcontainers upgrade but need to further check that. |
Unfortunately I can't run tests locally with the old version, probably due to this issue: testcontainers/testcontainers-java#1623 |
That was the issue I had to upgrade for. I can also debug tomorrow morning |
I tried without test containers upgrade and it seems to be working: https://travis-ci.org/github/jasync-sql/jasync-sql/builds/745282931 |
@oshai I got it working. It was an annoying behavior change from this PR: testcontainers/testcontainers-java#857 The fix was to override configure and change it back to "test". Also the "create the docker image during class initialization" is a not fun pattern to debug (especially when they swallow errors)... Would you be willing to accept some more PRs to clean that up and instead use JUnit's builtin ExternalResource? |
@rockwotj thanks for all the effort! |
Oops, I was just running the connection spec, now they should pass now I've fixed the default config values. |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
=============================================
+ Coverage 0 80.22% +80.22%
- Complexity 0 1032 +1032
=============================================
Files 0 259 +259
Lines 0 3792 +3792
Branches 0 474 +474
=============================================
+ Hits 0 3042 +3042
- Misses 0 531 +531
- Partials 0 219 +219
Continue to review full report at Codecov.
|
Thanks @rockwotj ! |
* Add client SSL configuration * Fix mysql tests after testcontainers upgrade * Fix up the default config for mysql tests
* Add client SSL configuration * Fix mysql tests after testcontainers upgrade * Fix up the default config for mysql tests
This is a minimal change to introduce client SSL configuration to the postgres driver.
This additionally upgrades the testcontainers dependency because it wouldn't start up otherwise on MacOS.
Fixes #213