Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currentSchema to ConnectionPoolConfiguration #282

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

Yomanz
Copy link
Contributor

@Yomanz Yomanz commented Jan 15, 2022

I was making a PR to quill and realized I forgot to add currentSchema here.

@oshai
Copy link
Contributor

oshai commented Jan 16, 2022

Please fix the build, right now it fails on formatting. How to fix: https://github.com/jasync-sql/jasync-sql/blob/master/CONTRIBUTING.md#building-locally

Let me know if you need assistance.

@Yomanz
Copy link
Contributor Author

Yomanz commented Jan 16, 2022

Please fix the build, right now it fails on formatting. How to fix: https://github.com/jasync-sql/jasync-sql/blob/master/CONTRIBUTING.md#building-locally

Let me know if you need assistance.

/home/runner/work/jasync-sql/jasync-sql/db-async-common/src/main/java/com/github/jasync/sql/db/ConnectionPoolConfiguration.kt:193:39: Not a valid Kotlin file (expecting an argument) (cannot be auto-corrected)

This sounds like an issue with the linter, I am also unable to run it locally.

@oshai
Copy link
Contributor

oshai commented Jan 16, 2022

the linter is from older version that is why you see the error. I will update it someday.
Anyway, I wasn't able to to add changes to this pr, so I added them here: #283

@oshai oshai merged commit 75b8539 into jasync-sql:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants