Win32 Console API: GetStdHandle, WriteConsole, GetCurrentConsoleFont #251

tmyroadctfig · 2013-07-23T06:59:58Z

Added:

GetStdHandle()
WriteConsole()
GetCurrentConsoleFont()

I've added in a test for WriteConsole and GetCurrentConsoleFont but they don't pass from IDEA. I'm assume that's because there is no console window displayed.

…tests.

twall · 2013-07-23T11:11:37Z

contrib/platform/src/com/sun/jna/platform/win32/Wincon.java

+        /**
+         * The index of the font in the system's console font table.
+         */
+        public WinDef.DWORD nFont;


As a matter of style, make this library interface extend WinDef so that any part of the interface or its derivations can reference DWORD instead of WinDef.DWORD. DWORD is common enough to warrant dropping the prefix.

dblock · 2013-07-23T11:51:08Z

Looks great. Please check out @twall's comment and also update CHANGELOG. Thank you!

Code review changes.

tmyroadctfig · 2013-07-24T01:28:52Z

Those changes are in now.

Cheers, Luke

dblock · 2013-07-30T10:15:27Z

I checked these out. On my Windows 7, 64-bit the three new tests fail with "invalid handle". I didn't see anything immediately wrong with the code, and wrote the same thing in C++, which worked, just to see if there's something different on my machine specifically.

tmyroadctfig · 2013-07-30T10:18:02Z

I think that's because the console font will only be defined if there is one of those black cmd.exe windows. The tests failed for me under IDEA and I was thinking that was the reason.

Did you run the tests via ant inside a command prompt? I haven't check that case myself actually.

dblock · 2013-07-30T10:42:27Z

I thought that too, but I also tried the equivalent of this, which creates a console if it doesn't exist:

 AllocConsole();
 stdout = GetStdHandle( STD_OUTPUT_HANDLE );
 WriteConsole(stdout, "Test", 4, &count, NULL );
 FreeConsole();

Didn't see whether the command line version succeeds, but I suspect it doesn't. I'll have a Windows PC in front of me today or tomorrow and can try this if you haven't gotten to it yet.

dblock · 2013-07-30T10:43:54Z

Btw, I think there's something fishy with the signed/unsigned handle values, I believe the result from GetStdHandle is indeed invalid with this code.

dblock · 2013-08-02T12:06:27Z

Confirming that these tests fail command-line, too.

dblock · 2013-09-25T11:22:39Z

Bump.

Conflicts: CHANGES.md contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java

# Conflicts: # contrib/platform/src/com/sun/jna/platform/win32/Wincon.java

tmyroadctfig · 2016-01-08T03:14:28Z

Sorry this got forgotten. I looks like most of my changes got copied in via some other change.

Can you please review this newly added structures for WinNT, Winioctl, etc?

lgoldstein · 2016-01-10T05:53:07Z

contrib/platform/src/com/sun/jna/platform/win32/Ntddk.java

+    public static final int FILE_DEVICE_ACPI = 0x00000032;
+    public static final int FILE_DEVICE_BATTERY = 0x00000029;
+    public static final int FILE_DEVICE_BEEP = 0x00000001;
+    public static final int FILE_DEVICE_BUS_EXTENDER = 0x0000002a;


This should be an interface (as indicated also by the Javadoc)

Please drop the public static final as this is the default for interfaces

lgoldstein · 2016-01-10T05:56:12Z

I recommend waiting a little while until pull request #574 is merged and then change the getFieldsOrder method(s) of the various new Structure(s) to use the createFieldsOrder method, as demonstrated by the pull request changes

# Conflicts: # contrib/platform/src/com/sun/jna/platform/win32/Winioctl.java

tmyroadctfig · 2016-01-11T00:06:13Z

OK, I've updated the code here to switch over to match the changes in #574 as suggested. Hopefully this is ready to review again.

lgoldstein · 2016-01-11T05:15:55Z

contrib/platform/src/com/sun/jna/platform/win32/WinNT.java

+        public PROCESSOR_RELATIONSHIP processor;
+
+        public SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX()
+        {}


Don't leave this empty - better to add the call to super() - even though it is implicit, as this enables placing a debug breakpoint in the constructor.

lgoldstein · 2016-01-11T05:23:54Z

Besides the specific (minor) comments:

Add a line in CHANGES.md with this pull request details (see other lines)
Squash everything to a single commit (you currently have 13...) so we can merge this as a one "atomic" change

…AP_EJECTSUPPORTED and SPDRP_FRIENDLYNAME. Added SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX, MEMORY_BASIC_INFORMATION64, STORAGE_DEVICE_DESCRIPTOR, DISK_GEOMETRY_EX, and related structures

ForNeVeR · 2016-09-17T11:44:51Z

The title of this PR is misleading: there're no WriteConsole in the current JNA code base neither in this PR.

tmyroadctfig · 2016-09-19T00:46:15Z

The title is a bit out of date and I probably won't have any time in the near future to tidy up the code ready to merge. Closing this off for now.

tmyroadctfig added 2 commits July 23, 2013 15:57

Add some win32 console functions.

e21d8b8

Tweak win32 console function signature. Add some constants. Add some …

8c5798a

…tests.

twall reviewed Jul 23, 2013
View reviewed changes

tmyroadctfig added 2 commits July 24, 2013 09:15

Add some win32 console functions.

cefafaf

Code review changes.

Add a change log entry

c58cc11

Merge branch 'master' of https://github.com/twall/jna

a00c197

Conflicts: CHANGES.md contrib/platform/src/com/sun/jna/platform/win32/Kernel32.java contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java

dblock added needs work and removed improvement labels Jun 24, 2014

dblock force-pushed the master branch from b313167 to 0ce5802 Compare March 16, 2015 15:55

dblock mentioned this pull request Apr 29, 2015

Added GetEnvironmentStrings to 'com.sun.jna.platform.win32.Kernel32' #434

Merged

tmyroadctfig added 4 commits January 8, 2016 12:26

Merge branch 'master' of https://github.com/twall/jna

4c99594

# Conflicts: # contrib/platform/src/com/sun/jna/platform/win32/Wincon.java

Add some more win32 structures and constants.

3c4cba3

Fix import layout.

93c78e6

Fix import layout.

ca73e19

lgoldstein reviewed Jan 10, 2016
View reviewed changes

tmyroadctfig added 4 commits January 11, 2016 10:04

Convert Ntddk to an interface.

51c7cc6

Merge branch 'master' of https://github.com/twall/jna

4d1cc1f

# Conflicts: # contrib/platform/src/com/sun/jna/platform/win32/Winioctl.java

Switch newly added structures to use createFieldsOrder.

32f4b06

Revert some unintentional changes.

600f3cb

lgoldstein reviewed Jan 11, 2016
View reviewed changes

tmyroadctfig added 6 commits January 11, 2016 16:26

Code review changes.

6ce5b73

Add a change log entry.

44b6d73

Fix an accidental change.

3919835

Code review changes.

5325d0f

Added CfgMgr32 constants, Ntddk constants, SetupApi constants CM_DEVC…

e28bf58

…AP_EJECTSUPPORTED and SPDRP_FRIENDLYNAME. Added SYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX, MEMORY_BASIC_INFORMATION64, STORAGE_DEVICE_DESCRIPTOR, DISK_GEOMETRY_EX, and related structures

Merge branch 'master' of github.com:tmyroadctfig/jna

44d7f28

tmyroadctfig closed this Sep 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Win32 Console API: GetStdHandle, WriteConsole, GetCurrentConsoleFont #251

Win32 Console API: GetStdHandle, WriteConsole, GetCurrentConsoleFont #251

tmyroadctfig commented Jul 23, 2013

twall Jul 23, 2013

dblock commented Jul 23, 2013

tmyroadctfig commented Jul 24, 2013

dblock commented Jul 30, 2013

tmyroadctfig commented Jul 30, 2013

dblock commented Jul 30, 2013

dblock commented Jul 30, 2013

dblock commented Aug 2, 2013

dblock commented Sep 25, 2013

tmyroadctfig commented Jan 8, 2016

lgoldstein Jan 10, 2016

lgoldstein commented Jan 10, 2016

tmyroadctfig commented Jan 11, 2016

lgoldstein Jan 11, 2016

lgoldstein commented Jan 11, 2016

ForNeVeR commented Sep 17, 2016 •

edited

Loading

tmyroadctfig commented Sep 19, 2016

Win32 Console API: GetStdHandle, WriteConsole, GetCurrentConsoleFont #251

Win32 Console API: GetStdHandle, WriteConsole, GetCurrentConsoleFont #251

Conversation

tmyroadctfig commented Jul 23, 2013

twall Jul 23, 2013

Choose a reason for hiding this comment

dblock commented Jul 23, 2013

tmyroadctfig commented Jul 24, 2013

dblock commented Jul 30, 2013

tmyroadctfig commented Jul 30, 2013

dblock commented Jul 30, 2013

dblock commented Jul 30, 2013

dblock commented Aug 2, 2013

dblock commented Sep 25, 2013

tmyroadctfig commented Jan 8, 2016

lgoldstein Jan 10, 2016

Choose a reason for hiding this comment

lgoldstein commented Jan 10, 2016

tmyroadctfig commented Jan 11, 2016

lgoldstein Jan 11, 2016

Choose a reason for hiding this comment

lgoldstein commented Jan 11, 2016

ForNeVeR commented Sep 17, 2016 • edited Loading

tmyroadctfig commented Sep 19, 2016

ForNeVeR commented Sep 17, 2016 •

edited

Loading