Added GetEnvironmentStrings to 'com.sun.jna.platform.win32.Kernel32' #434
Conversation
lgoldstein
force-pushed
the
env-vars-pull-request
branch
3 times, most recently
from
04bfbc1
to
054394a
Compare
| for (Entry<String, String> entry : environment.entrySet()) { | ||
| if (entry.getValue() != null) { | ||
| out.append(entry.getKey() + "=" + entry.getValue() + "\0"); | ||
| String key=entry.getKey(), value=entry.getValue(); |
There was a problem hiding this comment.
Space/tab? Make sure there're spaces around = please, so String key = entry.getKey(), value = entry.getValue();
There was a problem hiding this comment.
This has been the style of changes I submitted in the past and no one remarked about it. I have taken notice and will make an effort to have future submissions adhere to this style. As far as this submission goes, I would ask that you accept this change as-is, since back-formatting all the code I wrote with the spaces around the assignment operator would be tedious (I know Eclipse has a formatting option but I am afraid that other formatting issues will appear that may not be the way you like it - unless you can send me the exact configuration file for the Eclipse style).
There was a problem hiding this comment.
I overlooked this before, it's not that important, but it looks sloppy to future developers - I'll take it, but I would appreciate if you could look into auto-formatting this and others (I don't have the exact Eclipse configuration, sorry), and maybe run something automatic for a future commit. We would like to make JNA look like it was written by 1 person.
There was a problem hiding this comment.
Duly noted (though I disagree with looks sloppy...) - I do agree with make JNA look like it was written by 1 person and will adhere to this code style in the future.
|
This is good work, btw, really appreciate more contributions around win32 mappings! |
|
|
|
I would say the next big thing is fixing some of the tests that are inconsistently failing, https://github.com/twall/jna/labels/unit%20tests. Then #282, #258 and #251 that were PRed but either didn't have tests or issues. |
lgoldstein
force-pushed
the
env-vars-pull-request
branch
from
054394a
to
16b72e5
Compare
|
Done - renamed as discussed and pushed |
|
As far as #251 is concerned, it should be re-worked on my (previous) submission regarding the console API . |
| assertCallSucceeded("Clean up variable", Kernel32.INSTANCE.SetEnvironmentVariable(name, null)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I would have split this into Kernel32EnvironmentTest and Kernel32UtilEnvironmentTest, but I'll accept it as is.
Added GetEnvironmentStrings to 'com.sun.jna.platform.win32.Kernel32'
Including code to parse the resulting Pointer in Kernel32Utils (wait a moment for the CHANGES.md - the chicken and egg issue...)