Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GetClientRect #702

Merged
merged 4 commits into from
Sep 11, 2016
Merged

Added GetClientRect #702

merged 4 commits into from
Sep 11, 2016

Conversation

jonatino
Copy link
Contributor

Added GetClientRect function to get the size of the Window excluding the borders.

@jonatino
Added GetClientRect
4e39119 
Added GetClientRect function to get the size of the Window excluding the borders.
@matthiasblaesing
Copy link
Member

This looks good - two things please:

  • Add an entry for the change to CHANGES.md
  • review the the javadoc for GetWindowRect and GetClientRect, for both the return value is described wrong (it is mapped to boolean, the description is copied from MSDN, so it needs adjustment), the RECT param could then also be adapted.

Thank you!

@jonatino
Copy link
Contributor Author

@matthiasblaesing done.

@matthiasblaesing matthiasblaesing merged commit 84cc379 into java-native-access:master Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatino @matthiasblaesing