Main-Class in jna-platform.jar collides with java 9 module system #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The java 9 module system expects the main class to reside in the same jar, as the MANIFEST.MF. For the jna.jar the use case is valid to retrieve the current version of JNA, as jna.jar must be available to run jna-platform.jar, there is no use-case to have the Main-Class defined. As reference the explanation from the jigsaw-dev mailing list: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-April/012151.html
matthiasblaesing
force-pushed
the
remove_platform_main_class
branch
from
64b08db
to
f942fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The java 9 module system expects the main class to reside in the same
jar, as the MANIFEST.MF. For the jna.jar the use case is valid to
retrieve the current version of JNA, as jna.jar must be available
to run jna-platform.jar, there is no use-case to have the Main-Class
defined.
As reference the explanation from the jigsaw-dev mailing list:
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-April/012151.html