Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNLP-generation: path for dependency-lib on windows with backslash #182

Closed
FibreFoX opened this issue Mar 4, 2016 · 4 comments
Closed

Comments

@FibreFoX
Copy link
Member

FibreFoX commented Mar 4, 2016

http://stackoverflow.com/questions/35758949/how-to-specify-the-jnlp-output-file-when-using-javafx-maven-plugin-for-creating/35773771?noredirect=1#comment59234018_35773771

I'm able to deploy the javafx app with web start using the javafx-maven-plugin.but when I add other dependency(fontawesome jar) to pom,the jar is copied to lib directory. path to the jar in the jnlp file is <jar href="lib\fontawesomefx-8.9.jar"size="571068" download="null" /> which results in an error xitException[ 3]com.sun.deploy.net.FailedDownloadException: Unable to load resource: localhost:8080/installer/lib\fontawesomefx-8.9.jar.when I modify the path by changing the backward slash to a forward slash it works .Correct path localhost:8080/installer/lib/fontawesomefx-8.9.jar –

Might be a bug inside lib-path-generation or inside JDK (to be determined)

@FibreFoX
Copy link
Member Author

FibreFoX commented Mar 4, 2016

http://hg.openjdk.java.net/openjfx/8u-dev/rt/file/7a0629ba396d/modules/fxpackager/src/main/java/com/oracle/tools/packager/jnlp/JNLPBundler.java#l746

The jar-references are created with relative file-path, which generated system-specific dividers (\ on windows)

@FibreFoX FibreFoX self-assigned this Mar 6, 2016
FibreFoX added a commit to FibreFoX/javafx-maven-plugin that referenced this issue Mar 6, 2016
this should fix
- issue javafx-maven-plugin#182 by replacing backslash with normal slash
- wrong size for resource-jars by recalculating and replacing with new size
@FibreFoX FibreFoX closed this as completed Mar 6, 2016
@lilyevsky
Copy link

I just tried the 8.4.0 release, and this bug is still there. Am I doing something wrong, or indeed the bug was not fixed?

@FibreFoX
Copy link
Member Author

@lilyevsky what bundler are you using? Are you setting <bundler>jnlp</bundler> or are you generating this via mvn jfx:web? What JDK-version are you using?

@FibreFoX
Copy link
Member Author

Leaving this here for reference: Already got reported ! but closed as incomplete :(
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8144165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants