Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signing generated/copied jars using jnlp-bundler #185

Closed
FibreFoX opened this issue Mar 4, 2016 · 2 comments
Closed

signing generated/copied jars using jnlp-bundler #185

FibreFoX opened this issue Mar 4, 2016 · 2 comments
Assignees

Comments

@FibreFoX
Copy link
Member

FibreFoX commented Mar 4, 2016

http://stackoverflow.com/questions/35758949/how-to-specify-the-jnlp-output-file-when-using-javafx-maven-plugin-for-creating/35773771?noredirect=1#comment59271303_35773771

Also how do we sign the jar ? when I try to sign using the maven-jarsigner-plugin it signs the original jar created by maven but doesn't sign the jar file ending with -fx.jar (The jar that's created by this plugin)? How do we sign the jar and all the dependencies ?

As there is no buildin option for the new JNLP-bundler, we have to sign the jars afterwards like it happened inside web-mojo.

@FibreFoX
Copy link
Member Author

FibreFoX commented Mar 5, 2016

After signing the sizes inside JNLP-file are not correct, this has to be fixed too (wasn't even working when using web-mojo by calling mvn jfx:web)

@FibreFoX FibreFoX self-assigned this Mar 6, 2016
@FibreFoX
Copy link
Member Author

FibreFoX commented Mar 6, 2016

Signing and size-calculation is done within pull-request #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant