Enable content security policy by default #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about:blank works for all browsers and doesn't use inline javascript therefore doesn't violate a content security policy which prohibits inline script.
innerHTML is unsafe; use document.createElement to create elements then set attributes on them.
Move the BOOMR.init call to boomerang.min.js and include boomerang.min.js using a script tag. Use attributes on the script tag to pass necessary data to the script which is used to call BOOMR.init.
Avoid a CSP inline script violation. See: prototypejs/prototype#320
Move all inline CSS and inline Javascript to monitoring.css and monitoring.js
Since no javascript is dynamically generated, methods to escape javascript are no longer necessary or used.
The $$ is used to select elements by CSS selector only
`#` cannot be used because it's used to indicate message keys to lookup. So instead use alternative representations that don't use `#`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #966 by @candrews