Bug fix to strictly match Prometheus format spec + rename last_result… #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to last_value in metric names for consistency. Modified MonitoringController.java - set the proper ContentType header for Prometheus format Modified PrometheusController.java - change '_last_result_' to '_last_value_' in metric names for consistency. - remove the "fields" extension from the # HELP and # TYPE lines to conform to Prometheus format spec
|
merged |
goldyliang
pushed a commit
to goldyliang/javamelody
that referenced
this pull request
Mar 17, 2022
… to last_value in metric names for consistency. (javamelody#684) Modified MonitoringController.java - set the proper ContentType header for Prometheus format Modified PrometheusController.java - change '_last_result_' to '_last_value_' in metric names for consistency. - remove the "fields" extension from the # HELP and # TYPE lines to conform to Prometheus format spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to last_value in metric names for consistency.
Modified MonitoringController.java
Modified PrometheusController.java
Apologies for the second PR.