Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #700 - Reorg Prometheus output for multiple caches+connectors #709

Conversation

StefanPenndorf
Copy link
Contributor

  • Reorganize output to match Prometheus requirements on help lines and
    statistics output
  • Optimized sanitation by extracting patterns into constants
  • Optimized/cleaned up controller methods

…nnectors

- Reorganize output to match Prometheus requirements on help lines and
statistics output
- Optimized sanitation by extracting patterns into constants
- Optimized/cleaned up controller methods
@evernat
Copy link
Member

evernat commented Dec 15, 2017

I have tried an alternative approach which is not bad I think.
It is attached here as diff and as plain source. (And I have included your change on patterns.)
The result is the same as yours (at least the same as StefanPenndorf@dbcedcf).
What approach would be better for your and why? (My code is shorter ;-)

javamelody.prometheus.diff.txt
PrometheusController.java.txt

@evernat
Copy link
Member

evernat commented Dec 26, 2017

This PR replaced by the alternative approach in 6f06e46 which is merged and ready for the next release (1.71).
Thanks anyway for testing the fixed result and for this PR approach.
There will be a new snapshot build available in about 24h here:
https://javamelody.ci.cloudbees.com/job/javamelody/net.bull.javamelody$javamelody-core/

@evernat evernat closed this Dec 26, 2017
@StefanPenndorf StefanPenndorf deleted the fixes-700-prometheus-refactored branch April 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants