Add the ability to upload the heap dump to S3 bucket #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salahqasem
force-pushed
the
javamelody-s3
branch
from
7de27bb
to
c150db1
Compare
|
Merged, thanks. I will refactor a bit, including parameters names and dependencies to optional. |
|
See doc for the changed configuration (scroll down if the target page does not scroll to the right chapter). |
|
AWESOME, thanks! |
goldyliang
pushed a commit
to goldyliang/javamelody
that referenced
this pull request
Mar 17, 2022
goldyliang
pushed a commit
to goldyliang/javamelody
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you have the option to upload the heap dump to s3 bucket. to do that you should configure the following system properties.
1- enable.s3.heapDump=
true2-s3.bucketName=
<your s3 bucketname>3-region=
<s3 region>this property is optional. if it's not provided it will be replaced by Regions.DEFAULT_REGION from aws lib.