Issue 2669 infinite recursion object javassist for java.lang.Object supertype #2693

MysterAitch · 2020-05-22T15:00:26Z

…l, added `#isJavaLangObject()` and `#isJavaLangObject()` to reduce repetition throughout the codebase, made `#getParent()` return Optional, added TypeSolver#getSolvedJavaLangObject() to return a solved reference to `java.lang.Object` to avoid repetition of this throughout the codebase, note that this is a suggested commit message from intellij following a rebase.. probably okay, but noted here anyway just in case..

javaparser-core/src/main/java/com/github/javaparser/ast/nodeTypes/NodeWithExtends.java

...ain/java/com/github/javaparser/resolution/declarations/ResolvedReferenceTypeDeclaration.java

...ver-core/src/main/java/com/github/javaparser/symbolsolver/javaparsermodel/TypeExtractor.java

javaparser-core/src/main/java/com/github/javaparser/resolution/types/ResolvedReferenceType.java

...java/com/github/javaparser/symbolsolver/javaparsermodel/contexts/CompilationUnitContext.java

...avaparser/symbolsolver/javaparsermodel/declarations/JavaParserAnonymousClassDeclaration.java

.../github/javaparser/symbolsolver/javaparsermodel/declarations/JavaParserClassDeclaration.java

...c/main/java/com/github/javaparser/symbolsolver/javassistmodel/JavassistClassDeclaration.java

...ore/src/main/java/com/github/javaparser/symbolsolver/model/typesystem/ReferenceTypeImpl.java

...thub/javaparser/symbolsolver/javaparsermodel/declarations/JavaParserEnumDeclarationTest.java

...ing/src/test/java/com/github/javaparser/symbolsolver/model/typesystem/ReferenceTypeTest.java

...-solver-testing/src/test/java/com/github/javaparser/symbolsolver/resolution/ContextTest.java

MysterAitch · 2020-05-22T16:20:52Z

Ooh interesting, this fails on java 12 -- seemingly due to the addition of java.lang.constant.Constable...

Another one to add to #1701 ?

[ERROR] Failures: 
[ERROR]   ReferenceTypeTest.testDirectAncestorsOfClassWithInterfaces:706 
Expected: iterable with items ["java.lang.CharSequence", "java.lang.Object", "java.lang.Comparable<java.lang.String>", "java.io.Serializable"] in any order
     but: not matched: "java.lang.constant.Constable"
[INFO] 
[ERROR] Tests run: 1083, Failures: 1, Errors: 0, Skipped: 3

…hod have either `orElseThrow` or the logic around it's use has been edited to make use of `isPresent()` / `ifPresent()`

… optional, and all uses of this method have either `orElseThrow` or the logic around it's use has been edited to make use of `isPresent()` / `ifPresent()`

…rs to `java.lang.String`

…o issue_2669_infinite_recursion_object_javassist

MysterAitch · 2020-05-23T18:54:55Z

Ooh interesting, this fails on java 12 -- seemingly due to the addition of java.lang.constant.Constable...

Another one to add to #1701 ?

[ERROR] Failures: 
[ERROR]   ReferenceTypeTest.testDirectAncestorsOfClassWithInterfaces:706 
Expected: iterable with items ["java.lang.CharSequence", "java.lang.Object", "java.lang.Comparable<java.lang.String>", "java.io.Serializable"] in any order
     but: not matched: "java.lang.constant.Constable"
[INFO] 
[ERROR] Tests run: 1083, Failures: 1, Errors: 0, Skipped: 3

Yes, an issue with JDK 12 adding Constable and ConstantDesc which makes the test invalid.

https://docs.oracle.com/en/java/javase/12/docs/api/java.base/java/lang/String.html

I have added an enum and helper methods to AbstractSymbolResolutionTest which can be used to detect the current java version, thus allows tests to be run on specific Java versions.

This feels very "hacky" thus is immediately marked as as deprecated to strongly discourage its use in the future as anything other than a quick workaround, though it may be a potential solution to #1701 .

…y made -- see javaparser#2695 where I was corrected re: the null checks within `setImports()`

…y that it is only the explictly extended types that should be returned (i.e. those that are specified within the AST)

…ntially can re-introduce it as part of a separate PR...

…viour )due to my confusion about whether ancestors includes implicit ancestors or not, and whether getDirectAncestors should do so -- see also javaparser#2696 )

… -- edited to fix/undo a previous change that introduced a change in behaviour )due to my confusion about whether ancestors includes implicit ancestors or not, and whether getDirectAncestors should do so -- see also javaparser#2696 )

MysterAitch added 3 commits May 22, 2020 15:41

modified comment

c6d6bd8

run generators and tests following rebase

5f06176

MysterAitch added the API or Behaviour Change Issues / PRs where there is potentially a breaking change label May 22, 2020