Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2578 Orphaned Comments exist but not printed on unrelated change to AST #2916

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Nov 13, 2020

Fixes #2578 .

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #2916 (00fcc40) into master (2e55995) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2916   +/-   ##
=======================================
  Coverage   52.21%   52.22%           
=======================================
  Files         438      438           
  Lines       23436    23436           
  Branches     3535     3535           
=======================================
+ Hits        12238    12240    +2     
+ Misses      10286    10283    -3     
- Partials      912      913    +1     
Flag Coverage Δ
AlsoSlowTests 52.22% <100.00%> (+<0.01%) ⬆️
jdk-10 52.22% <100.00%> (+<0.01%) ⬆️
jdk-11 52.22% <100.00%> (+<0.01%) ⬆️
jdk-12 52.22% <100.00%> (+<0.01%) ⬆️
jdk-13 52.22% <100.00%> (+<0.01%) ⬆️
jdk-14 52.22% <100.00%> (+<0.01%) ⬆️
jdk-15 52.22% <100.00%> (+<0.01%) ⬆️
jdk-8 52.22% <100.00%> (+<0.01%) ⬆️
jdk-9 52.22% <100.00%> (+<0.01%) ⬆️
macos-latest 52.21% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 52.21% <100.00%> (+<0.01%) ⬆️
windows-latest 52.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../github/javaparser/printer/PrettyPrintVisitor.java 95.39% <100.00%> (ø)
...ub/javaparser/ast/nodeTypes/NodeWithModifiers.java 68.96% <0.00%> (+3.44%) ⬆️
...st/nodeTypes/modifiers/NodeWithPublicModifier.java 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e55995...00fcc40. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orphaned Comments exist but not printed on unrelated change to AST
2 participants