Skip to content

Fix issue 2535 Comments within method missing indentation #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2020
Merged

Fix issue 2535 Comments within method missing indentation #2918

merged 5 commits into from
Nov 13, 2020

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Nov 13, 2020

Fixes #2535 .

@MysterAitch MysterAitch added this to the next release milestone Nov 13, 2020
@MysterAitch
Copy link
Member

Looks like it was just a few remaining test cases to amend to accommodate the fix 👍

@jlerbsc
Copy link
Collaborator Author

jlerbsc commented Nov 13, 2020

Thanks for your help.

@jlerbsc jlerbsc merged commit efb242d into javaparser:master Nov 13, 2020
@jlerbsc jlerbsc deleted the issue2535 branch November 13, 2020 23:44
MysterAitch added a commit to MysterAitch/javaparser that referenced this pull request Nov 15, 2020
@MysterAitch
changelog entries for javaparser#2758 javaparser#2892 javaparser#2895 #
501bfb7 
javaparser#2896 javaparser#2900 javaparser#2916 javaparser#2914 javaparser#2918 javaparser#2920 javaparser#2921 javaparser#2893 javaparser#2902 javaparser#2903 javaparser#2906 javaparser#2915 javaparser#2907 javaparser#2901 javaparser#2913
@MysterAitch MysterAitch mentioned this pull request Nov 15, 2020
Merged
@MysterAitch MysterAitch added the API or Behaviour Change Issues / PRs where there is potentially a breaking change label Nov 15, 2020
@MysterAitch
Copy link
Member

Added the behaviour change label as this corrects / changes in how code is printed (as shown in the changed tests).

MysterAitch added a commit to MysterAitch/javaparser that referenced this pull request Nov 15, 2020
@MysterAitch
flagged javaparser#2918 in the changelog as a behaviour change
7b598cb
@MysterAitch MysterAitch mentioned this pull request Nov 17, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

API or Behaviour Change Issues / PRs where there is potentially a breaking change

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

Comments within method missing indentation

2 participants

@jlerbsc @MysterAitch