Fix issue 2951 #2952
Merged
Fix issue 2951 #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MysterAitch For me it's a good patch. We can merge it. Thanks for your contribution @qzchenwl . |
|
Thanks @qzchenwl -- really appreciate your PR! The javassist side of things is one that I don't have much insight to but @jlerbsc likes it (I'm not sure why I was tagged), the tests pass (thank you for including tests!), and the fix seems reasonable enough! If any problems surface later we can always revert it -- so in it goes!! 😃 |
To have a second opinion ;-) |
MysterAitch
added a commit
to MysterAitch/javaparser
that referenced
this pull request
Dec 1, 2020
…2654, javaparser#2959, javaparser#2948, javaparser#2949, javaparser#2950, javaparser#2955, javaparser#2957, javaparser#2942, javaparser#2958, javaparser#2927, javaparser#2930, javaparser#2931, javaparser#2938, javaparser#2945, javaparser#2947, javaparser#2952, javaparser#2956, javaparser#2954, javaparser#2939, javaparser#2961, javaparser#2966)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2951.