Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-scope and ScopeIdentifiersTransformer: rename identifiers in more easy way #503

Merged
merged 10 commits into from
Jan 18, 2020
Merged

eslint-scope and ScopeIdentifiersTransformer: rename identifiers in more easy way #503

merged 10 commits into from
Jan 18, 2020

Conversation

sanex3339
Copy link
Member

Fixes #496

@sanex3339
Copy link
Member Author

sanex3339 commented Jan 16, 2020 •
edited
Loading

Still need to do more refactoring, but the main work is done

@sanex3339 sanex3339 mentioned this pull request Jan 16, 2020
Closed
@coveralls
Copy link

coveralls commented Jan 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 98.596% when pulling 2b6e65a on eslint-scope into 7ba1ed3 on master.

vladdekhanov
vladdekhanov approved these changes Jan 17, 2020
View reviewed changes
...ers-transformer/variable-declaration/fixtures/variable-call-before-variable-declaration-2.js Outdated
})();o
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible it could be a reason of bug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@sanex3339 sanex3339 mentioned this pull request Jan 17, 2020
Closed
@sanex3339
Copy link
Member Author

Anybody can test this branch?

@sanex3339 sanex3339 mentioned this pull request Jan 18, 2020
Closed
@sanex3339 sanex3339 merged commit 3b51296 into master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladdekhanov vladdekhanov vladdekhanov approved these changes

@zamotkin zamotkin Awaiting requested review from zamotkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong obfuscation that make a runtime error
3 participants
@sanex3339 @coveralls @vladdekhanov