Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency lift + appropriate code changes and adjusted README since … #45

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

mppperez
Copy link
Contributor

Fix for issue #43

…stringArrayEncoding is expected to be a string array
@nicholaslee119
Copy link

@mppperez Thanks for your work!
I check out your repo and built it locally, It seems to work well itself and return right { ast: ast } But, after passing the { ast: ast } to Metro, I can not get right bundle.js which should be obfuscated by this plugin.

@mppperez
Copy link
Contributor Author

mppperez commented Apr 7, 2021

hi @nicholaslee119, could u provide a sample? I've just compared the bundle.js of my previous app version with old javascript obfuscator with the new one and it looks fine for me (only obfuscating app code not the third party libraries).

this discussion may be better in an own issue here referencing this PR.

best regards

@HyperNovax
Copy link

Perfect, this branch fixes the problems. The obfuscating is good but the application crashes on startup :

05-05 13:59:47.348 28558 28591 E AndroidRuntime: com.facebook.react.common.d: ReferenceError: Can't find variable: styles, stack:
05-05 13:59:47.348 28558 28591 E AndroidRuntime: <unknown>@1551:924
05-05 13:59:47.348 28558 28591 E AndroidRuntime: v@2:1473
05-05 13:59:47.348 28558 28591 E AndroidRuntime: <unknown>@1549:1296
05-05 13:59:47.348 28558 28591 E AndroidRuntime: v@2:1473
05-05 13:59:47.348 28558 28591 E AndroidRuntime: <unknown>@1515:961
05-05 13:59:47.348 28558 28591 E AndroidRuntime: v@2:1473
05-05 13:59:47.348 28558 28591 E AndroidRuntime: <unknown>@471:923
05-05 13:59:47.348 28558 28591 E AndroidRuntime: v@2:1473
05-05 13:59:47.348 28558 28591 E AndroidRuntime: <unknown>@405:228
05-05 13:59:47.348 28558 28591 E AndroidRuntime: v@2:1473
05-05 13:59:47.348 28558 28591 E AndroidRuntime: <unknown>@6:57
05-05 13:59:47.348 28558 28591 E AndroidRuntime: v@2:1473
05-05 13:59:47.348 28558 28591 E AndroidRuntime: d@2:875
05-05 13:59:47.348 28558 28591 E AndroidRuntime: global code@1612:3

@TheMatrixMaster
Copy link

What is the progress on this PR? I am also encountering this issue when bundling my app. @mppperez @nicholaslee119

@mppperez
Copy link
Contributor Author

Unfortunately I do not have permission to merge the PR or make a release. You would need to apply the changes manually for now if you want to continue to use this lib.

I guess this will be my last PR for this as well (had another one for fixes with RN > 0.59) since it seems like this project won't be ressurected anymore although there are still many ppl left using it. Any suggestion for a good alternative are welcome ... probably ending up using javascript-obfuscator directly as already mentioned in #15

@geraintwhite
Copy link

@sanex3339 could this be merged? I've been running it in my app using a private fork for months with no issues

@sanex3339
Copy link
Member

I can merge it but i can't release it

@sanex3339 sanex3339 merged commit 453019e into javascript-obfuscator:master Apr 7, 2022
@geraintwhite
Copy link

geraintwhite commented Apr 8, 2022

I can merge it but i can't release it

Who can release it? @ds300 can you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants