Ready to go online #346

EzequielCaste · 2020-08-11T21:18:56Z

Hi @iliakan 👋

With 115 of 174 articles already translated, we are ready to go online, if you consider appropriate. 🚀

Let us know what you think ;)

Cheers!

iliakan · 2020-08-12T03:28:49Z

Yeah, let's do that! =)

Please translate these YAML files (engine localizations for Spanish):

locales.zip

(Unzip, translate the phrases and zip again, keeping the structure).

EzequielCaste · 2020-08-12T12:30:35Z

Ok great!
I'm working on it 👍

EzequielCaste · 2020-08-12T13:49:43Z

locales.zip

Done! 🎉

joaquinelio · 2020-08-12T16:49:34Z

I'll start a big pull from EN.

maints, I'll leave ya this, click the delousing monkey:
articles left, date claimed
https://joaquinelio-zone17.glitch.me/

wishing many young folks learning here...

iliakan · 2020-08-12T20:08:10Z

Please take a look at https://es.javascript.info/

EzequielCaste · 2020-08-12T20:16:18Z

Looking great!! :) Happy to finally see some progress after all this time.

…

On Wed, Aug 12, 2020, 17:08 Ilya Kantor ***@***.***> wrote: Please take a look at https://es.javascript.info/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#346 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMLHWQQ2ECFQZ2C4ZN7LVSTSALZDTANCNFSM4P3SM2MQ> .

iliakan · 2020-08-12T20:47:16Z

I enabled CI, so any pushes to this repo get to the site automatically.

iliakan · 2020-08-12T20:49:12Z

I'm also going to add translation leads to the page https://es.javascript.info/about

BTW, is it true? @vplentinax did more than 50% of the translation?

EzequielCaste · 2020-08-12T21:02:14Z

@vplentinax she did the sincronization of the old translated files to the newer versions. Updating old translations.

I hope contributors names were not lost in the process.

iliakan · 2020-08-12T21:09:07Z

The contributor for each line is tracked by git. You must have heard about the git blame command.

Usually it's reliable. But if an operation forces git to recognize the file as a new one, then the authorship for all lines is updated to the committer.

That's probably what has happened. Definitely not good.

EzequielCaste · 2020-08-12T21:14:42Z

BTW, I've changed my username in Github from ezzep66 to EzequielCaste. Is is possible to update it in the about page?

iliakan · 2020-08-12T21:16:02Z

To fix that, an article should be fully recommitted, right now (late evening) no bright ideas about that, maybe you can suggest something?

@EzequielCaste the author details are almost impossible to change without recommitting. The author info is stored in Git repo, not on github (that's just a wrapper around Git). It's a part of the commit hash.

joaquinelio · 2020-08-12T22:02:25Z

The contributor for each line is tracked by git. You must have heard about the git blame command.

Usually it's reliable. But if an operation forces git to recognize the file as a new one, then the authorship for all lines is updated to the committer.

That's probably what has happened. Definitely not good.

"Blame" should be useful, but it is nearly empty for many files here. I didn't care too much.
But.
I wonder if this is what causes a problem I'm dealing with now.
Pulling from English upstream tries to OVERWRITE SOME traslated files. NO conflicts shown.
I CAN'T TRUST IT! We need a trustworthy sync method, we shouldnt do it manually with our eyes.

I have 3 remotes, origin, upstrem (es) enstream (en)
merge upstream, ok
then
merge enstream, lots of conflicts, ok
but some files are replaced by english version with no conflict at all

D:\js\es.javascript.info\1-js\99-js-misc\04-reference-type\3-why-this\task.md
D:\js\es.javascript.info\1-js\99-js-misc\04-reference-type\3-why-this\solution.md

task.md , ok - (cant remember, either goes staged or shows conflict, but it IS OK).
solution.md - goes straight to the merge like no 3way is there.

I'm a novice on git. Coudnt find any useful from git log
I guess I'll put an issue?

joaquinelio · 2020-08-12T22:17:32Z

LOVE IT ❤️

Yes, Valentina vplentinax DID A LOT. She pushed the repo ahead, translations and reviews.
I like this too
According to your browser headers, you know English. Please help to translate the tutorial. Thank you!

We could use some new blood

"about"
HEY! Don't encourage TRANSLATORS only.
we need REVIEWERS, the hard part.
But it's ok, I was chasing people with solid background among them. It payed well. The site is a beauty.

I can die now. ✌️

iliakan · 2020-08-13T12:00:12Z

Pulling from English upstream tries to OVERWRITE SOME traslated files. NO conflicts shown.
but some files are replaced by english version with no conflict at all

@joaquinelio I think I saw it too once, but don't remember what's causing it. I'd like to check out an example.

EzequielCaste · 2020-08-13T21:06:06Z

I enabled CI, so any pushes to this repo get to the site automatically.

Merged an article yesterday: Capturing groups #345

Online version has not been updated. Does this take some time? or is the update automatic?

iliakan · 2020-08-13T21:10:30Z

@EzequielCaste sorry, my typo, now should work =)

EzequielCaste · 2020-08-13T21:53:37Z

Thank you @iliakan 🙏
One last favor I ask from you today...

since I changed my username, the Issue #17 Information gets overwritten:

Maintainer List
@lizzie136, @vplentinax, @ezzep66, @joaquinelio, @maksumi

can you please update my data?
I think the bot overwrites with original username, it should be @EzequielCaste

iliakan · 2020-08-14T05:43:14Z

Done. Added maintainers at https://es.javascript.info/about =)

iliakan · 2020-08-14T05:45:39Z

Please translate this:

es.yml.zip

joaquinelio · 2020-08-14T08:06:33Z

ok I'm on it. ✍️

joaquinelio · 2020-08-14T10:00:10Z

Last line: "tutorial -is- English"?

hey pals: @EzequielCaste , @maksumi

dash - ¿","? Not natural. Not happy. Queda un poco forzado.
maintainer ... == ¿Mantenedor? prefero el título github!
markup ... ==
es.yml.zip

iliakan · 2020-08-14T10:12:06Z

@joaquinelio what's wrong with the last line? It just states that the Spanish version is a translation of the English one.

By the way, do you know that you can translate text in images too?
For example, here:

We use SVG format for images, so no need to use graphics editor for that. Just translate the text.
Here are the details: https://github.com/javascript-tutorial/server#translating-images

iliakan · 2020-08-14T10:12:45Z

@joaquinelio is the es.yml.zip from your message a finished translation? or I'd better wait?

joaquinelio · 2020-08-14T10:53:14Z

SVG,
I know that, I read about tha yaml in the server readme. It's Sad magicimg (or something) is not working for me yet. I'm dealing with the pull issue now.

Edit: Wow. That example DESERVES translation. I guess I'll look at it. Maybe just a missing path.

yaml Last line
"This is the translated version of the tutorial is English"
sound odd
to wait or not to wait...
It depends.
Nothing too wrong, it's good enough.
But It doesnt seem urgent, no need to waste time, just a check.

iliakan · 2020-08-14T10:57:41Z

Maybe I should rephrase it?
Ok, I'll wait then.

joaquinelio · 2020-08-14T12:20:49Z

Maybe I should rephrase it?

This is the translated version of the tutorial -in- English, maybe?
Again, not my language.

iliakan · 2020-08-14T12:27:06Z

Oh, a typo there! Right, corrected 🙄

iliakan · 2020-08-14T12:27:30Z

Thank you so much.

iliakan · 2020-08-14T12:27:54Z

Now I feel stupid for not understanding you.

joaquinelio · 2020-08-14T12:46:26Z

Says the man who created this entire multi-soul project

But it's ok, nobody understands me.
👍

EzequielCaste · 2020-08-14T14:03:43Z

We use SVG format for images, so no need to use graphics editor for that. Just translate the text.
Here are the details: https://github.com/javascript-tutorial/server#translating-images

Hi @iliakan I'm trying to install the server, following the instructions above, I get this error after the command edit es

[11:01:52] 'webpack' errored after 4.28 s
[11:01:52] ValidationError: Invalid options object. Copy Plugin has been initialized using an options object that does not match the API schema.
 - options[0] misses the property 'patterns'. Should be:
   [non-empty string | object { from, to?, context?, globOptions?, toType?, force?, flatten?, transform?, cacheTransform?, transformPath?, noErrorOnMissing? }, ...] (should not have fewer than 1 item)
 - options[1] misses the property 'patterns'. Should be:
   [non-empty string | object { from, to?, context?, globOptions?, toType?, force?, flatten?, transform?, cacheTransform?, transformPath?, noErrorOnMissing? }, ...] (should not have fewer than 1 item)
    at validate (C:\Users\ezzep\js\server\node_modules\copy-webpack-plugin\node_modules\schema-utils\dist\validate.js:96:11)
    at new CopyPlugin (C:\Users\ezzep\js\server\node_modules\copy-webpack-plugin\dist\index.js:24:30)
    at Object.module.exports [as webpack] (C:\Users\ezzep\js\server\modules\config\webpack.js:316:7)
    at Promise (C:\Users\ezzep\js\server\tasks\webpack.js:7:36)
    at new Promise (<anonymous>)
    at module.exports (C:\Users\ezzep\js\server\tasks\webpack.js:6:9)
    at C:\Users\ezzep\js\server\modules\engine\gulp\requireModuleTasks.js:11:12
    at taskWrapper (C:\Users\ezzep\js\server\node_modules\undertaker\lib\set-task.js:13:15)
    at bound (domain.js:425:14)
    at runBound (domain.js:438:12)
    at asyncRunner (C:\Users\ezzep\js\server\node_modules\async-done\index.js:55:18)
    at processTicksAndRejections (internal/process/task_queues.js:79:9)
[11:01:52] 'edit' errored after 4.28 s

Any thoughts how to solve this?

iliakan · 2020-08-14T14:07:22Z

Please show me the versions:

cat node_modules/webpack/package.json | grep '"version"'
cat node_modules/copy-webpack-plugin/package.json | grep '"version"'

EzequielCaste · 2020-08-14T14:13:11Z

"version": "4.44.1", "version": "6.0.3"

iliakan · 2020-08-14T14:17:15Z

That's strange: package.json has "copy-webpack-plugin": "^4.5.2".
So it really should be 4, not 6.

EzequielCaste · 2020-08-14T14:24:43Z

Ok rolled back to original version. I may hay updated the version..

Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js): ModuleBuildError: Module build failed (from ./node_modules/css-loader/dist/cjs.js): Error: Can't resolve '/img/subscribe_bg.svg' in 'C:\Users\ezzep\js\server\tmp\en'

EzequielCaste · 2020-08-14T14:31:46Z

Module execa was missing from my modules...

It's working now, at least on my localhost.

EzequielCaste · 2020-08-14T14:53:15Z

ok almost got it...

/article/coding-style/code-style.svg: Could not execute GraphicsMagick/ImageMagick: identify "-ping" "-format" "{"width":%w,"height":%h}" "C:\Users\ezzep\js\server\public\en\article\coding-style\code-style.svg" this most likely means the gm/convert binaries can't be found

joaquinelio · 2020-08-14T15:18:58Z

@EzequielCaste

Welcome to the point I quit!
I guess it lacks PATH entry

Can you please check es.yml.zip from... uhm... comment 5 hours before this?
Plis don't drop the entire transl...

es.yml.zip
original
10 hours before this...

it really should show the comment ID

maksumi · 2020-08-14T15:59:03Z

Last line: "tutorial -is- English"?

hey pals: @EzequielCaste , @maksumi

dash - ¿","? Not natural. Not happy. Queda un poco forzado.
maintainer ... == ¿Mantenedor? prefero el título github!
markup ... ==
es.yml.zip

Ponme en contexto @joaquinelio

joaquinelio · 2020-08-19T21:40:10Z

@iliakan
Well, no reviewers for this.
It's ok, you can use it. Some changes from the last one.

es.yml.zip

Anything else to be done here?

EzequielCaste · 2020-08-19T21:44:10Z

Sorry @joaquinelio I didn't quite understand what you meant. 🤷‍♂️

We're you waiting for me to review this?

EzequielCaste · 2020-08-19T21:50:37Z

Closing this, since we are ONLINE now and I was able to translate the SVG images.

joaquinelio · 2020-08-20T16:53:08Z

new issue?
es.js.cx’s server IP address could not be found.

//es.javascript.info/event-delegation

2.2.3 article.md (still English)
line 14 [iframe height=350 src="bagua" edit link]

buttons:
plunker is working
new window is not: //es.js.cx/article/event-delegation/bagua/

iliakan · 2020-08-20T16:58:03Z

Should be ok now, is it?

joaquinelio · 2020-08-20T16:59:01Z

that was fast 👍

iliakan · 2020-08-20T17:10:47Z

Please also check out https://es.javascript.info/about

EzequielCaste closed this as completed Aug 19, 2020

iliakan reopened this Aug 20, 2020

iliakan closed this as completed Aug 20, 2020

Ready to go online #346

Ready to go online #346

Comments

EzequielCaste commented Aug 11, 2020

iliakan commented Aug 12, 2020 • edited Loading

EzequielCaste commented Aug 12, 2020

EzequielCaste commented Aug 12, 2020

joaquinelio commented Aug 12, 2020

iliakan commented Aug 12, 2020

EzequielCaste commented Aug 12, 2020 via email

iliakan commented Aug 12, 2020

iliakan commented Aug 12, 2020

EzequielCaste commented Aug 12, 2020

iliakan commented Aug 12, 2020 • edited Loading

EzequielCaste commented Aug 12, 2020

iliakan commented Aug 12, 2020 • edited Loading

joaquinelio commented Aug 12, 2020

joaquinelio commented Aug 12, 2020 • edited Loading

iliakan commented Aug 13, 2020 • edited Loading

EzequielCaste commented Aug 13, 2020

iliakan commented Aug 13, 2020

EzequielCaste commented Aug 13, 2020

iliakan commented Aug 14, 2020 • edited Loading

iliakan commented Aug 14, 2020

joaquinelio commented Aug 14, 2020

joaquinelio commented Aug 14, 2020

iliakan commented Aug 14, 2020

iliakan commented Aug 14, 2020

joaquinelio commented Aug 14, 2020 • edited Loading

iliakan commented Aug 14, 2020

joaquinelio commented Aug 14, 2020 • edited Loading

iliakan commented Aug 14, 2020

iliakan commented Aug 14, 2020

iliakan commented Aug 14, 2020

joaquinelio commented Aug 14, 2020

EzequielCaste commented Aug 14, 2020 • edited Loading

iliakan commented Aug 14, 2020

EzequielCaste commented Aug 14, 2020

iliakan commented Aug 14, 2020 • edited Loading

EzequielCaste commented Aug 14, 2020

EzequielCaste commented Aug 14, 2020

EzequielCaste commented Aug 14, 2020

joaquinelio commented Aug 14, 2020 • edited Loading

maksumi commented Aug 14, 2020

joaquinelio commented Aug 19, 2020

EzequielCaste commented Aug 19, 2020

EzequielCaste commented Aug 19, 2020

joaquinelio commented Aug 20, 2020

iliakan commented Aug 20, 2020

joaquinelio commented Aug 20, 2020

iliakan commented Aug 20, 2020

iliakan commented Aug 12, 2020 •

edited

Loading

iliakan commented Aug 12, 2020 •

edited

Loading

iliakan commented Aug 12, 2020 •

edited

Loading

joaquinelio commented Aug 12, 2020 •

edited

Loading

iliakan commented Aug 13, 2020 •

edited

Loading

iliakan commented Aug 14, 2020 •

edited

Loading

joaquinelio commented Aug 14, 2020 •

edited

Loading

joaquinelio commented Aug 14, 2020 •

edited

Loading

EzequielCaste commented Aug 14, 2020 •

edited

Loading

iliakan commented Aug 14, 2020 •

edited

Loading

joaquinelio commented Aug 14, 2020 •

edited

Loading