Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings #126

Merged
merged 9 commits into from Jun 18, 2020
Merged

Strings #126

merged 9 commits into from Jun 18, 2020

Conversation

ferueda
Copy link
Contributor

@ferueda ferueda commented Dec 6, 2019

String article and tests (tasks and solutions) translated to spanish.

alert( checkSpam("innocent rabbit") );
alert( checkSpam('compra ViAgRA ahora') );
alert( checkSpam('xxxxx gratis') );
alert( checkSpam("coneja inocente") );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo el cambio solicitado aquí.

@@ -1,23 +1,23 @@
# Strings

In JavaScript, the textual data is stored as strings. There is no separate type for a single character.
En JavaScript, los datos textuales son almacenados como strings (cadena de caracteres). No hay un tipo de datos separado para caracteres únicos.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'unitarios' en lugar de 'únicos'. Puesto que se refiere a la cantidad de caracteres no a la exclusividad.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alert( checkSpam("innocent rabbit") );
alert( checkSpam('compra ViAgRA ahora') );
alert( checkSpam('xxxxx gratis') );
alert( checkSpam("coneja inocente") );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo el cambio solicitado aquí.

@ferueda
Copy link
Contributor Author

ferueda commented Dec 13, 2019

/done

@ferueda
Copy link
Contributor Author

ferueda commented Jan 7, 2020

It looks like no one is reviewing these pull requests from the community. If you need help revewing them I can help as a reviewer.

@joaquinelio joaquinelio changed the title Strings article translated to spanish Strings Jun 8, 2020
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambié Un mont+on!!!!!!!!!! Falta ahora:

  • Restaurar un ejercicio (lo marqué)
  • 79 - Restaurar una tabla y retraducirla.(faltan items y descripciones)
  • 135, 150 - Revisar formato con inglés: el suggest arruina los marckup triple comilla `
    VOLVERÉ con un editor bueno

1-js/05-data-types/03-string/1-ucfirst/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/1-ucfirst/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/1-ucfirst/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/3-truncate/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/3-truncate/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

37 cambios que me atreví a hacer sin permiso
tildes, gramática, y err de concepto mas lineas que no habian sido traducidas adrede
Actualización grossa
ortografía
@joaquinelio joaquinelio merged commit fb3b99c into javascript-tutorial:master Jun 18, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants