Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules, introduction #198

Merged
merged 2 commits into from
May 27, 2020

Conversation

EzequielCaste
Copy link
Contributor

No description provided.

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue #17, it's 197 ⁉️

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me gusta.
Me gustarían algunos cambios pero es gusto personal o cosas que no hacen al JS...

y tenemos 70 y pico de PR por meter, el doble de review

1-js/13-modules/01-modules-intro/article.md Outdated Show resolved Hide resolved
1-js/13-modules/01-modules-intro/article.md Outdated Show resolved Hide resolved
1-js/13-modules/01-modules-intro/article.md Show resolved Hide resolved
@EzequielCaste EzequielCaste merged commit 4ad4b7f into javascript-tutorial:master May 27, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

@ezzep66 ¡Qué emoción!
log

Una cosita... El bot sugiere 2 reviewers (quedó colgado el status needs+1) , cmo maintainer es tu prerrogativa no hacerle caso ¿vamos a trabajar así?
Por mí BIEN, prefiero que se filtre algún errorcito a ver que diluye por falta de interés como el año pasado. Además cuando se termine el resto se pueden revisar los PR cerrados ver cuál necesita rechequeo, no me preocupa.

Era deprimente el mensaje "last commit" parado un año. Podemos decir que avanza,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants