Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixins #271

Merged
merged 3 commits into from
Jul 12, 2020
Merged

Mixins #271

merged 3 commits into from
Jul 12, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jun 22, 2020

Replacing PR #177

@javascript-translate-bot javascript-translate-bot requested a review from a team June 22, 2020 11:03
@iliakan iliakan mentioned this pull request Jun 22, 2020
Open
joaquinelio
joaquinelio requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sé cómo sacar el .gitattributes del PR
Por las dudas no pongo merge hasta que lo rehagas sin ese archivo (¿trabajas online o local?)
o que lo arregle alguien que sepa más.

El resto, solo 2 correciones.

1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
1-js/09-classes/07-mixins/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg
Copy link
Contributor Author

cortizg commented Jul 11, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 03:14
@cortizg
Copy link
Contributor Author

cortizg commented Jul 11, 2020

listo @joaquinelio restauré .gitattributes

joaquinelio
joaquinelio approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment says so I do

@vplentinax vplentinax self-requested a review July 11, 2020 18:34
@cortizg @joaquinelio
Update 1-js/09-classes/07-mixins/article.md
f7ea2e4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg
Copy link
Contributor Author

cortizg commented Jul 11, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 19:12
vplentinax
vplentinax approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@vplentinax vplentinax merged commit a5824b0 into javascript-tutorial:master Jul 12, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax