Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic operators, maths #314

Merged

Conversation

EzequielCaste
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 22, 2020 15:14
@EzequielCaste EzequielCaste changed the title traducción completa de 08 operators Basic operators, maths Jul 22, 2020
@joaquinelio joaquinelio self-requested a review July 22, 2020 19:14
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Uh, miren quén está vivo!
¿Un año sabático de un par de dias?
qué perezoso

Con este aporte casi se lee de corrido la primera parte!!!!!!
salvo el exmantainer ric

edit:
ah, no da para review, pero la version inglés 1 2 8 3 solution,
hacen "fix" (¿?) agregan ESPACIOS en lineas 13 y 14... NO ENTIEDO POR QUÉ

edit2:
No está basado en el EN de hace 3 meses
cambia def, titulos y agrega algunas linas al articulo

1-js/02-first-steps/08-operators/1-increment-order/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/08-operators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 10 commits July 22, 2020 19:16
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…ions/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…ions/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@EzequielCaste
Copy link
Contributor Author

/done

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO LO RELEÍ apenass miré lo que puso maksumi.
Supongo que arreglaste los tipos,
y solo te disscutiría los err de concepto pero no había visto ninguno, so...
apruebo sin leer.

Copy link
Collaborator

@maksumi maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo hay unas nuevas sugerencias que veo necesarias, consideralaspor favor. De ahí en fuera: approve!


```js run
let a = "1"; // prompt("First number?", 1);
let b = "2"; // prompt("Second number?", 2);
let a = "1"; // prompt("Primer número?", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De hecho no... Leelo con tono de pregunta. @joaquinelio

EzequielCaste and others added 3 commits July 23, 2020 09:38
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
…ions/solution.md

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@EzequielCaste EzequielCaste merged commit 33f3ea4 into javascript-tutorial:master Jul 23, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants