Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling with promises #329

Merged
merged 7 commits into from Jul 31, 2020
Merged

Error handling with promises #329

merged 7 commits into from Jul 31, 2020

Conversation

george28cs
Copy link
Contributor

Hola, envío el PR correspondiente a la traducción de "Manejo de errores con promesas".

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@george28cs george28cs changed the title promises error handling v0 promises error handling Jul 29, 2020
@joaquinelio joaquinelio changed the title promises error handling Error handling with promises Jul 29, 2020
@iliakan iliakan mentioned this pull request Jul 29, 2020
Open
@joaquinelio joaquinelio self-requested a review July 29, 2020 15:50
joaquinelio
joaquinelio requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@george28cs y reviewers
*Poco para corregir, no vi err de concepto,
ojalá un reviewer con más espalda JS que la mia lo mire...

*Tu PR está OK, Los archivos son los correctos y se ve muy bien.
*El nombre del PR debe ser exactamente (mayusc incluida) para que bot lo registre, nada grave, casi siempre lo modificamos a mano (cambié el nombre y actualicé el issue17).

NOTA: *Los arch originales inglés fueron modificados ayer y se generaron 2 conflictos:
Uno lo arreglé directamente en el traducido (el otro era gramatica inglés, no nos afecta)

1-js/11-async/04-promise-error-handling/article.md Outdated Show resolved Hide resolved
1-js/11-async/04-promise-error-handling/article.md Outdated Show resolved Hide resolved
1-js/11-async/04-promise-error-handling/article.md Outdated Show resolved Hide resolved
1-js/11-async/04-promise-error-handling/article.md Outdated Show resolved Hide resolved
1-js/11-async/04-promise-error-handling/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

george28cs and others added 5 commits July 29, 2020 18:07
@george28cs @joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
016922b 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs @joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
2119ff6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs @joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
26000d8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs @joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
bd63d4d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs @joaquinelio
Update 1-js/11-async/04-promise-error-handling/article.md
e51ca46 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs
Copy link
Contributor Author

/done

joaquinelio
joaquinelio approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien...
a 2do reviewer, ¿es suficientemente clara la explicacion? promise, then, try, catch, y anidados...

vplentinax
vplentinax approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcto, fluido. @joaquinelio , todos los conceptos se entienden bien.

@vplentinax vplentinax merged commit 2dfdbb3 into javascript-tutorial:master Jul 31, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@george28cs @CLAassistant @javascript-translate-bot @joaquinelio @vplentinax