Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream @ e074a5f8 #383

Closed
wants to merge 91 commits into from
Closed

Conversation

javascript-translate-bot

This PR was automatically generated to merge changes from en.javascript.info at e074a5f

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

Click to open a list of 33 files

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

paroche and others added 30 commits February 6, 2020 23:36
My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
"// obj.toString === obj.__proto__.toString == Object.prototype.toString"
It is look like JS code but it gives different result from what we want to get.
There is different kind of equality operator ant these give more confusing what is the purpose of these?
It can be better to separate this line into 2 line of code to make it sensible and readable.
Subject and code is already hard but there is no need to make readers ask unnecessary questions.
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Adding the missin closing bracket.
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 18 committers have signed the CLA.

✅ leviding
✅ Violet-Bora-Lee
✅ yoga1234
✅ joaquinelio
✅ iliakan
✅ LitStronger
✅ vsemozhetbyt
❌ leeyc0
❌ paroche
❌ haond10adp
❌ lumosmind
❌ peachesontour
❌ pushpend3r
❌ henchies
❌ MuhammedZakir
❌ apcurran
❌ cristian-wang
❌ Jarvis-3000
You have signed the CLA already but the status is still pending? Let us recheck it.

@joaquinelio
Copy link
Member

joaquinelio commented Sep 21, 2020

No hacer este MERGE

Edit: Nada mal,
Se redujo y se hizo manejable como esperábamos, excelente.

Pero

1 Nros de linea no respetados complican la edicion.

2 Hay que ser CUIDADOSO en revisar, se muestran CLARAMENTE como conflictos >>> === <<< (fácil de resolver) pero no los trata como tales, presumiblemente sobrescribirá la linea traducida.

3 corrige SVG
@EzequielCaste Esto reemplaza svg traducidos por otros con otro nombre ¿habria que hacer tu proceso de nuevo?

@joaquinelio
Copy link
Member

@vplentinax
SSi todos fueran conflictos simples se podrian resolver aqui (con el debido cuidado)

Pero hay articulos totalmente trastocados (de origen) y es mejor tener las herramientas ide.
Cierro este.
Esstoy resolviendo localmente y voy a escribir el procedimiento... a ver si al fin me desprendo de esto

@EzequielCaste
No hace meerge de Los SVG, los sobreescribe porque los toma como binarios.
No sé cómo evitar que los sobrescriba, el merge pendiente no me da opcion a elegir "ours" como en los md (por lo menos en el ide) aunque sí lo podria evitar en mi pr

Pero se supone que el svg fue arreglado de alguna forma
El pr que voy a poner pisa 2 svg con ingles 5-5-fetch cross origin (creo que es lo que corresponde),
si no los seguis voy a qye tener que aprender a hacer funcionar tu procedimiento...

@joaquinelio joaquinelio marked this pull request as draft September 22, 2020 19:51
@joaquinelio joaquinelio marked this pull request as ready for review September 23, 2020 14:17
@joaquinelio
Copy link
Member

joaquinelio commented Sep 23, 2020

MERGE enabled again,
I guess it would add >>>> ==== <<<< stuff into the files

too tempting...
I'll put as draft again before I ruin the repo just for stating the point.

@joaquinelio joaquinelio marked this pull request as draft September 23, 2020 14:32
@joaquinelio joaquinelio deleted the sync-e074a5f8 branch December 21, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet