Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Conversions #57

Merged
merged 8 commits into from
Aug 22, 2019
Merged

Type Conversions #57

merged 8 commits into from
Aug 22, 2019

Conversation

tikoflano
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2019

CLA assistant check
All committers have signed the CLA.


There are also cases when we need to explicitly convert a value to the expected type.
Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

También

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you reviewed the wrong commit. That was fixed in the latest one.

I will update this PR with the translation of task and solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

@lizzie136 lizzie136 self-requested a review June 26, 2019 19:32
1-js/02-first-steps/06-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-type-conversions/article.md Outdated Show resolved Hide resolved

There are also cases when we need to explicitly convert a value to the expected type.
Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

@tikoflano
Copy link
Contributor Author

I fixed the typos. I'm curious about the "Tmabién" at line 7. I double checked that is ok in the "Files changed" of this PR.

- `undefined` is `NaN` as a number, not `0`.
- `"0"` and space-only strings like `" "` are true as a boolean.
- `undefined` es `NaN` como número, no `0`.
- `"0"` y textos que solo contienen espacios como `" "` son `true` como boolean.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quedaría mejor cadenas en lugar de textos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En todo el resto del artículo se usa la palabra "texto". Creo que "cadena" o "cadena de caracteres" puede confundir al lector ya que no se ha explicado lo que es.

Copy link
Member

@lizzie136 lizzie136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @tikoflano por estos cambios 🚀

@lizzie136 lizzie136 merged commit 9577373 into javascript-tutorial:master Aug 22, 2019
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants