Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline mode of anchors ^ $, flag "m" #259

Merged
merged 8 commits into from
Mar 15, 2023

Conversation

EhsanShahbazii
Copy link
Contributor

/done

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mahdyar
Copy link
Member

mahdyar commented Mar 14, 2023

Don't you think the word پرچم in Persian doesn't fit here? 🤔 Maybe flag itself would be a better option?
Let's have @mahdiHash's opinion on this as well.

@EhsanShahbazii
Copy link
Contributor Author

Don't you think the word پرچم in Persian doesn't fit here? 🤔 Maybe flag itself would be a better option?
Let's have @mahdiHash's opinion on this as well.

In the previous article that we translated, we used the word "پرچم". Of course, in my opinion, it is better that the words flag and anchor are not translated. But because we translated in the previous article, that's why I also translated.

@mahdiHash
Copy link
Contributor

Sorry for the delay. I was a little busy.

I also think "flag" is better. But it's translated to "پرچم" in other articles, so we need to revert it in another PR.

For now, please left "flag" as is, @EhsanShahbazii.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii
Copy link
Contributor Author

/done

Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new changes.

9-regular-expressions/05-regexp-multiline-mode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/05-regexp-multiline-mode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/05-regexp-multiline-mode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/05-regexp-multiline-mode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/05-regexp-multiline-mode/article.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new changes.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Mahdi Hashemi <mahdihashemiii939@gmail.com>
@EhsanShahbazii
Copy link
Contributor Author

/done

@mahdiHash
Copy link
Contributor

Thanks for your contribution, @EhsanShahbazii.

@mahdyar mahdyar merged commit b669507 into javascript-tutorial:master Mar 15, 2023
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants