Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status review for unfinished articles #416

Closed
Peruibeloko opened this issue Jan 7, 2024 · 17 comments
Closed

Status review for unfinished articles #416

Peruibeloko opened this issue Jan 7, 2024 · 17 comments

Comments

@Peruibeloko
Copy link
Contributor

I went over the translation checklist and classified each item in one of three categories:

  • Unchecked: Item is present in the master branch but not marked as done
  • Abandoned: Item has work present on a fork but the PR is either closed or absent
  • Untouched: Item is assigned to someone but it wasn't worked on at all

And this is the current status:

Item Status
Basic operators, math Unchecked (#217, #412)
Loops: while and for Abandoned (#50)
Functions Untouched
Object references and copying Unchecked
Symbol type Unchecked
Numbers Untouched (under @rnrnshn)
WeakMap and WeakSet Untouched (under @wnleao)
Object.keys, values, entries Abandoned
Destructuring assignment Untouched
Date and time Untouched
JSON methods, toJSON Abandoned (#185)
Recursion and stack Abandoned
Rest parameters and spread syntax Untouched
Variable scope, closure Untouched
The old "var" Untouched
Scheduling: setTimeout and setInterval Untouched
Function binding Untouched
Property getters and setters Abandoned
Class inheritance Untouched
Static properties and methods Untouched
Extending built-in classes Abandoned (#411)
Error handling, "try...catch" Untouched
Custom errors, extending Error Abandoned
Introduction: callbacks Abandoned
Promise Untouched
Error handling with promises Untouched (under @wnleao)
Promise API Untouched
Promisification Untouched (under @wnleao)
Microtasks Untouched (under @wnleao)
Async/await Untouched
Modules, introduction Untouched
Currying Untouched
Browser environment, specs Abandoned
DOM tree Abandoned
Walking the DOM Abandoned
Attributes Review pending (broken mention @denis-rossati)
Introduction to browser events Untouched (broken mention to @cesarkohl)
Form properties and methods Untouched (broken mention to @recalderon)
Fetch Abandoned (broken mention to @vitorinoaraujo)
Bezier curve Abandoned (broken mention to @lucastrvsn)
JavaScript animations Abandoned (broken mention to @karlasamantha)
Template element Untouched (broken mention to @HakaCode)

We can solve some of these problems as such:

  • Abandoned articles can be resumed through a new PR
  • Untouched articles assigned over a certain period (6 months, 1 year) can be safely unassigned and reopened for translation
  • Unchecked articles can be safely checked for updated tracking

What does everyone think?

@odsantos
Copy link
Contributor

odsantos commented Jan 7, 2024

@Peruibeloko I agree but we probably need to be sure that Untouched topics have no PR, so three months might also be a good waiting period. Thanks.

@Peruibeloko
Copy link
Contributor Author

@odsantos most of the Untouched topics are months or years out of date with master. I can go over them and append the age of the assignment if you'd like

@odsantos
Copy link
Contributor

odsantos commented Jan 7, 2024

@Peruibeloko no, there is no need, as long as no work is present this seems good. Thanks.

@Peruibeloko
Copy link
Contributor Author

Glad to help, let me know if you need anything!

@HakaCode
Copy link
Contributor

HakaCode commented Jan 7, 2024

@Peruibeloko @odsantos

I will arrange it as soon as possible, I had forgotten to translate, thank you for reminding me.

@Peruibeloko
Copy link
Contributor Author

@HakaCode thanks! Just a quick reminder to keep the PR contained to the specific as article you're translating!

@HakaCode
Copy link
Contributor

HakaCode commented Jan 7, 2024

@Peruibeloko @odsantos I think now I just wait for it to be reviewed and accepted.

@danilolmc
Copy link
Contributor

Hey guys!

About the Extending built-in classes article, I'm now just waiting a review in the #413 PR

I also translated these two articles below, but they are unchecked even thought I created their pull request with their article titles:

How can I mark them as checked?

@Peruibeloko
Copy link
Contributor Author

@danilolmc I didn't include your class extension article since I remember seeing you picking it one of these days.

Marking them as done is probably restricted to either the bot or @iliakan

@danilolmc
Copy link
Contributor

Great, thank you! @Peruibeloko

@jonnathan-ls
Copy link
Contributor

Abandoned articles can be resumed through a new PR

Instead of reopening the PR, we could contribute directly to it (PR number), and if the user's branch or repository is protected, then the task goes on to be reopened in a new PR, what do you think?

In reviews, I'm looking to contribute by adding commits directly to the user's forked repository that is associated with the PR, instead of just registering my comments for simple things, trying to speed up the merge process, instead of waiting for the user's response that may have abandoned the PR

@jonnathan-ls
Copy link
Contributor

jonnathan-ls commented Jan 13, 2024

Hey guys!
...
How can I mark them as checked?

@danilolmc

My deduction, the bot apparently did not act on the PRs because the merger was apparently carried out without following the necessary review steps (review and approval process) and perhaps because it failed to mark the PR's hash on the list due to absences in the approval and registration procedures of the task on behalf of the person.

Marking them as done is probably restricted to either the bot or iliakan

Maintainers have the permission to update PR #1.

I have updated the list considering the PRs have been completed.

@jonnathan-ls
Copy link
Contributor

I agree but we probably need to be sure that Untouched topics have no PR, so three months might also be a good waiting period. Thanks.

I agree with 03 months instead of 06, we need agility and evolution of this repository instead of waiting for PRs that haven't even been touched yet.

@savionascimentodev
Copy link

Hello everyone, I would really like to contribute to this repository, but I'm kind of new to open source projects, I saw that there are a lot of PRs open and after this list that @Peruibeloko sent, it gave me a little idea, but if I want to contribute , is there anyone active I can talk to?

Note: Or I just raise a Pr and who knows, one day it will be approved.

@danilolmc
Copy link
Contributor

Hey @savionascimentodev !

You can take a look at #1 issue.

Hope it can help you...

@Peruibeloko
Copy link
Contributor Author

@savionascimentodev Seja bem-vindo mano!

O processo é bem simples:

Esse é o resumo executivo, posso te auxiliar lá no #1 diretamente, já que aqui é mais voltado para outro assunto :D

@Peruibeloko
Copy link
Contributor Author

Vou fechar essa issue, já que conseguimos trazer atenção ao problema e movimentamos o #1

@Peruibeloko Peruibeloko closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants