Class basic syntax

[Benyaak]

Finished the class basic syntax lesson, I hope everything is okay. Waiting for a review/translation suggestions. Thanks a lot.

[Benyaak]

Solved all suggestion /done

[lighthousand]

@Benyaak, you're not a romanian native speaker, am i right ? :)

[lighthousand]

Overall, good job !

[javascript-translate-bot]

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

outdated

[iliakan]

You can't merge because of conflicts. Can you fix the conflicts (know what it is?)

[bogdanbacosca]

Yep but GitHub wouldn't let me edit the files. I think this person unticked the "let maintainers edit code" box

[iliakan]

Maybe check it out locally, merge/edit and then close this PR?

[bogdanbacosca]

I think he may have deleted his branch - checkout to Benyaak:master just creates a brand new branch. Also I cannot see his pull request in the GitHub desktop app, the other one shows up but not his.

Not sure exactly, I can copy/paste his code and modify it in a new branch because it seems like there are not so many mistakes, but not sure if it's "legal" or fair to do that. Translating one article is not that much work from my experience so far and I wouldn't mind to let go of it also.

Is there another way?

[iliakan]

 git fetch -fu origin refs/pull/40/head:pr/40
 git checkout pr/40

[bogdanbacosca]

me@os:~/Documents/GitHub/ro.javascript.info$ git fetch -fu origin refs/pull/40/head:pr/40
fatal: couldn't find remote ref refs/pull/40/head

[iliakan]

From this repo:

➜  ro.javascript.info git:(master) git fetch -fu origin refs/pull/40/head:pr/40
remote: Enumerating objects: 27, done.
remote: Counting objects: 100% (11/11), done.
remote: Total 27 (delta 11), reused 11 (delta 11), pack-reused 16
Unpacking objects: 100% (27/27), 6.31 KiB | 646.00 KiB/s, done.
From github.com:javascript-tutorial/ro.javascript.info
 * [new ref]           refs/pull/40/head -> pr/40

[iliakan]

I made a new branch tmp-40 with this PR and pushed it.

[iliakan]

See this PR #146

[bogdanbacosca]

thanks a lot 🙏️