Manuals and specifications #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lenchen1112
requested changes
Aug 28, 2019
|
Please make the requested changes. After it, add a comment "/done". |
竟然有這東西 lol |
ArvinH
reviewed
Aug 28, 2019
|
|
||
| - **MDN (Mozilla) JavaScript Reference** is a manual with examples and other information. It's great to get in-depth information about individual language functions, methods etc. | ||
| 你可以在這裡找到 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>. |
There was a problem hiding this comment.
根據上下文，或許可以改成這樣？
Suggested change
| 你可以在這裡找到 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>. | |
| 你可以從這裡尋找資訊 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>. |
|
@tom76kimo 你的 CLA 發生什麼事～ |
|
第一個 commit 用錯帳號的樣子~ |
|
@tom76kimo 是有沒要改～ |
lenchen1112
requested changes
Sep 3, 2019
|
Please make the requested changes. After it, add a comment "/done". |
lenchen1112
requested changes
Sep 3, 2019
|
Please make the requested changes. After it, add a comment "/done". |
|
記得 rebase master，要先 sync origin 的 commit 喔，不然 suggestion 的會沒打上去 |
Finish translation Apply suggestions from code review Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com> Co-Authored-By: ArvinH <arvin0731@gmail.com>
|
Updated |
ArvinH
approved these changes
Sep 5, 2019
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target chapter
1-js/01-getting-started/2-manuals-specificationsModified files
article.md