Coding Style #43
Merged
Coding Style #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaddopur
reviewed
Sep 17, 2019
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md
Outdated
Show resolved
Hide resolved
ArvinH
approved these changes
Sep 17, 2019
| ```warn header="There are no \"you must\" rules" | ||
| Nothing is set in stone here. These are style preferences, not religious dogmas. | ||
| ```warn header="沒有任何規則是 \"你一定得\" 採用的" | ||
| 沒有什麼規則是被刻在石頭上的，這只是風格喜好，不是宗教信條。 |
There was a problem hiding this comment.
[nit] 我是覺得直翻也不錯啦
Suggested change
| 沒有什麼規則是被刻在石頭上的，這只是風格喜好，不是宗教信條。 | |
| 沒有什麼規則是不可改變的，這只是風格喜好，不是宗教信條。 |
There was a problem hiding this comment.
這邊我猜是有摩西把天啓刻到石板的隱喻啦，所以直翻可能比較能保留這層意思
Co-Authored-By: Jason Huang <chaoju.huang@gmail.com>
kaddopur
approved these changes
Sep 29, 2019
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target chapter
1-js/03-code-quality/02-coding-styleModified files
article.md1-style-errors/*