Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using deprecated '-debug' fallback for parameter name resolution #1279

Closed
halexiev-hedgeserv opened this issue Mar 15, 2023 · 7 comments
Closed
Labels

Comments

@halexiev-hedgeserv
Copy link

halexiev-hedgeserv commented Mar 15, 2023

Is your feature request related to a problem? Please describe.
Javers code is currently compiled with the old '-debug' compiler flag which leads to following warning at runtime with spring:

Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead or avoid its introspection: org.javers.spring.auditable.aspect.JaversAuditableAspect

Describe the solution you'd like
As the warning suggests the code should be compiled with the newer '-parameters' flag.

Describe alternatives you've considered
This is warning currently, but in future versions of Spring this will error as the parameter name discoverer class (org.springframework.core.LocalVariableTableParameterNameDiscoverer) parsing the '-debug' compiled code will be removed.

@bartoszwalacik
Copy link
Member

sorry but where exactly this flag is switched on in our build process?

@halexiev-hedgeserv
Copy link
Author

halexiev-hedgeserv commented Mar 17, 2023

Good question. I looked around a bit and could not find it in the code, but I assume it's something that you get by default. Maybe it's worth trying setting explicitly the '-parameters' flag which should in theory replace the '-debug'.

compileJava { options.compilerArgs << '-parameters' }

@bartoszwalacik
Copy link
Member

since it's not in the code, how do you observe it?

@halexiev-hedgeserv
Copy link
Author

From logs at runtime :)

@bartoszwalacik
Copy link
Member

Are you going to contribute a PR?

@loowps
Copy link
Contributor

loowps commented Nov 8, 2023

@bartoszwalacik according to https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Versions 6.1 will be released this november where the deprecated LocalVariableTableParameterNameDiscoverer will be deleted.

@bartoszwalacik
Copy link
Member

fix will be available tomorrow in 7.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants